Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add Terraform 0.13 constraint and module attribution #792

Merged
merged 7 commits into from
Jan 27, 2021
Merged

feat!: add Terraform 0.13 constraint and module attribution #792

merged 7 commits into from
Jan 27, 2021

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Jan 23, 2021 •
edited

  • add Terraform 0.13 constraint and module attribution
  • fix examples for add_cluster_firewall_rules due to changes in the way data sources are read
  • fix for empty maps not being equal tomap({}) == {} evaluates to false due to type system issues

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners January 23, 2021 23:33
@comment-bot-dev
Copy link

comment-bot-dev commented Jan 23, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

morgante
morgante approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this. 🚀

@morgante morgante merged commit 32db990 into master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bharathkkb @comment-bot-dev @morgante