Add maintenance exclusions support #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgongora
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
msgongora
force-pushed
the
maintenance-exclusions
branch
from
633724a
to
013bb3c
Compare
|
Also to mention that we could improve this implementation when support to 0.12 is dropped and we could fully use variable validation for instance. Maintenance exclusion has some constraints or restrictions that I think we could address better with a higher terraform version. |
msgongora
force-pushed
the
maintenance-exclusions
branch
from
013bb3c
to
9bd0c60
Compare
bharathkkb
requested changes
Jan 9, 2021
There was a problem hiding this comment.
Thanks for the PR @msgongora
You will need to bump the example provider versions as well. Example
We will also be dropping support for 0.12 in next release.
msgongora
force-pushed
the
maintenance-exclusions
branch
from
9bd0c60
to
646bd0d
Compare
msgongora
force-pushed
the
maintenance-exclusions
branch
from
646bd0d
to
68c6cb2
Compare
done, I see |
bharathkkb
approved these changes
Jan 11, 2021
bmenasha
pushed a commit
to bmenasha/terraform-google-kubernetes-engine
that referenced
this pull request
Feb 17, 2023
* Add support to maintenance exclusions * Bump google-beta required_providers to 3.49.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #780
This feature has been GA for about a year but looking at the cluster template I realize most of the maintenance_policy features are still under beta, so I'm placing this PR under beta and probably I'm going to file another PR moving all those features, including this one, out of beta. Please let me know and I'll work on the 2nd PR as soon as I have time.