Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove provider config from module to be TF 0.13 compatible #777

Merged
merged 3 commits into from
Jan 8, 2021
Merged

feat: remove provider config from module to be TF 0.13 compatible #777

merged 3 commits into from
Jan 8, 2021

Conversation

xingao267
Copy link
Member

@xingao267 xingao267 commented Jan 7, 2021 •
edited by morgante

Fixes #677
Fixes #673

@xingao267 xingao267 marked this pull request as draft January 7, 2021 20:41
@comment-bot-dev
Copy link

comment-bot-dev commented Jan 7, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

@xingao267 xingao267 force-pushed the xingao branch 4 times, most recently from f84f5a4 to 538cbc6 Compare January 7, 2021 22:15
@xingao267 xingao267 changed the title DO NOT REVIEW YET remove provider config from module to be TF 0.13 compatible feat: remove provider config from module to be TF 0.13 compatible Jan 8, 2021
@xingao267 xingao267 marked this pull request as ready for review January 8, 2021 00:59
@xingao267
Copy link
Member Author

@morgante @bharathkkb could you help take a look at this PR?

@morgante
Copy link
Contributor

morgante commented Jan 8, 2021

@xingao267 Have you tested/confirmed this approach works with the Kubernetes functionality like creating a DNS map?

Note this would have to be marked as a breaking change, so please also include/start an upgrade guide.

@xingao267
Copy link
Member Author

xingao267 commented Jan 8, 2021 •
edited

@xingao267 Have you tested/confirmed this approach works with the Kubernetes functionality like creating a DNS map?

stub_domains_* tests and upstream_nameservers test cover creating the kubernetes_config_map resources and they seem fine. https://console.cloud.google.com/cloud-build/builds/0efe0e77-8334-4a7d-ad2f-af0c7dcc46c5;step=39?project=cloud-foundation-cicd

Note this would have to be marked as a breaking change, so please also include/start an upgrade guide.

I'll add it.

@bharathkkb
Copy link
Member

also fixes #673

@xingao267
Copy link
Member Author

/gcbrun

@xingao267 xingao267 mentioned this pull request Jan 8, 2021
Closed
@xingao267
Copy link
Member Author

@morgante ready to be merged

@morgante morgante merged commit 81b0a94 into master Jan 8, 2021
@morgante morgante deleted the xingao branch January 8, 2021 19:31
This was referenced Jan 9, 2021
Closed
Closed
@miteshr93 miteshr93 mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@xingao267 @comment-bot-dev @morgante @bharathkkb