Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added notification_config block to beta submodules #752

Merged
merged 6 commits into from Dec 2, 2020
Merged

feat: added notification_config block to beta submodules #752

merged 6 commits into from Dec 2, 2020

Conversation

odise
Copy link
Contributor

@odise odise commented Dec 1, 2020

@odise odise requested review from bharathkkb, Jberlinsky and a team as code owners December 1, 2020 15:54
@comment-bot-dev
Copy link

comment-bot-dev commented Dec 1, 2020 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @odise

autogen/main/cluster.tf.tmpl Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feat: added notification_config block feat: added notification_config block to beta submodules Dec 2, 2020
@bharathkkb bharathkkb merged commit 4a85321 into terraform-google-modules:master Dec 2, 2020
@odise odise deleted the cluster-notification branch December 2, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odise @comment-bot-dev @bharathkkb