Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloud Run load balancer configuration #740

Merged
merged 1 commit into from Nov 10, 2020

Conversation

Jberlinsky
Copy link
Contributor

@Jberlinsky Jberlinsky commented Nov 10, 2020

Exposes cloudrun_config.load_balancer_type when configuring beta clusters.

@Jberlinsky
Copy link
Contributor Author

Jberlinsky commented Nov 10, 2020

Test failure reported by bot doesn't appear to be relevant. Cloud Build is passing.

@Jberlinsky Jberlinsky marked this pull request as ready for review November 10, 2020 20:44
@Jberlinsky Jberlinsky requested review from bharathkkb and a team as code owners November 10, 2020 20:44
@Jberlinsky Jberlinsky changed the title [WIP] Add support for Cloud Run load balancer configuration Add support for Cloud Run load balancer configuration Nov 10, 2020
@morgante
Copy link
Contributor

@Jberlinsky Could you add this to one of the examples?

@morgante morgante merged commit 685a2db into master Nov 10, 2020
@morgante morgante deleted the feature/cloud-run-configuration-load-balancer-type branch November 10, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants