Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple cluster wait-for-cluster.sh #734

Merged
merged 1 commit into from Nov 3, 2020
Merged

fix: multiple cluster wait-for-cluster.sh #734

merged 1 commit into from Nov 3, 2020

Conversation

bharathkkb
Copy link
Member

fixes: #733
Changes:

  • match on equality key=value instead of pattern key:pattern using both cluster name and location
  • if current_status is empty, i.e filter did not match any cluster, exit with error

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners November 3, 2020 01:07
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 3, 2020 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 6682911 into master Nov 3, 2020
@bharathkkb bharathkkb deleted the fix-multicluster-wait-bug branch November 3, 2020 03:48
@bharathkkb bharathkkb mentioned this pull request Nov 3, 2020
Closed
@bharathkkb bharathkkb mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait-for-cluster.sh infinite loop when multiple clusters meet the filter name
3 participants
@bharathkkb @comment-bot-dev @morgante