Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable ACM feature on hub #722

Merged
merged 6 commits into from Dec 4, 2020
Merged

feat: Enable ACM feature on hub #722

merged 6 commits into from Dec 4, 2020

Conversation

cloud-pharaoh
Copy link
Contributor

No description provided.

@comment-bot-dev
Copy link

comment-bot-dev commented Oct 22, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

/gcbrun

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to enable hub on our test project, defined here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/setup/main.tf#L50

       Operation "operations/acf.66e7d7f4-f02b-4b8e-8168-cf64d1e1d6fc" finished successfully.
       API [gkehub.googleapis.com] not enabled on project [106532254158]. 
       Would you like to enable and retry (this will take a few minutes)? 
       (y/N)?  
       ERROR: (gcloud.alpha.container.hub.config-management.enable) PERMISSION_DENIED: GKE Hub has not been used in project 106532254158 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/gkehub.googleapis.com/overview?project=106532254158 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
       - '@type': type.googleapis.com/google.rpc.Help
         links:
         - description: Google developers console API activation
           url: https://console.developers.google.com/apis/api/gkehub.googleapis.com/overview?project=106532254158
       - '@type': type.googleapis.com/google.rpc.ErrorInfo
         domain: googleapis.com
         metadata:
           consumer: projects/106532254158
           service: gkehub.googleapis.com
         reason: SERVICE_DISABLED

@bharathkkb
Copy link
Member

We can also use the "gke-project-asm" which has hub already enabled

module "gke-project-asm" {

@cloud-pharaoh
Copy link
Contributor Author

@morgante @bharathkkb
I opted for adding enabling the hub API on project 2. I see a failure because of permissions. I need to grant the Hub Admin permission to the terraform SA. How can I do that?

@morgante
Copy link
Contributor

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

modules/acm/main.tf Show resolved Hide resolved
modules/acm/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit that we should specify additional_components incase user does not have alpha installed

modules/acm/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title Enable ACM feature on hub feat: Enable ACM feature on hub Dec 4, 2020
@bharathkkb bharathkkb merged commit c199dae into terraform-google-modules:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants