Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nodepool taints to keepers for update-variant #717

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

jinoobaek-qz
Copy link
Contributor

Add node_pool_taints to force new.

Add node_pool_taints to force new.
@comment-bot-dev
Copy link

comment-bot-dev commented Oct 17, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
We need to propagate this change to all the other modules by running make build. More details here.

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 5, 2021
@bharathkkb bharathkkb removed the Stale label Jan 9, 2021
@bharathkkb bharathkkb changed the title Update cluster.tf.tmpl feat: Add nodepool taints to keepers for update-variant Jan 9, 2021
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

bharathkkb commented Jan 12, 2021

I changed the logic from the initial PR based on the schema in node_config.go.

@morgante morgante merged commit 372a11c into terraform-google-modules:master Jan 12, 2021
@jmymy
Copy link
Contributor

jmymy commented Feb 16, 2021

FYI this forces recreation of all node pools since the random_id has a change

+/- resource "random_id" "name" {
      ~ b64_std     = "pool-01-XXX=" -> (known after apply)
      ~ b64_url     = "pool-01-XXX" -> (known after apply)
      ~ dec         = "pool-01-XXXX" -> (known after apply)
      ~ hex         = "pool-01-XXXX" -> (known after apply)
      ~ id          = "Thg" -> (known after apply)
      ~ keepers     = { # forces replacement
          + "taints"            = ""
            # (12 unchanged elements hidden)
        }
        # (2 unchanged attributes hidden)
    }

+/- resource "google_container_node_pool" "pools" {
      ~ id                  = "<REMOVED/pool-01-XXX" -> (known after apply)
      ~ instance_group_urls = [ ] -> (known after apply)
      ~ max_pods_per_node   = 110 -> (known after apply)
      ~ name                = "pool-01-XXX" -> (known after apply) # forces replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants