Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields for ACM and Config Sync to bring them to feature parity #635

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Update fields for ACM and Config Sync to bring them to feature parity #635

merged 3 commits into from
Aug 21, 2020

Conversation

williamjiuchengcai
Copy link
Contributor

This commit contains the new features in ACM/ Config Sync:

  1. sourceFormat option.
  2. hierarchyController.
  3. logDeniesEnabled in Policy Controller.

Testing being ran by linde@

@comment-bot-dev
Copy link

comment-bot-dev commented Aug 19, 2020 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

@williamjiuchengcai williamjiuchengcai force-pushed the acm-config-sync branch 9 times, most recently from 80b7025 to daafa84 Compare August 19, 2020 23:27
@morgante morgante merged commit 7fc3b48 into terraform-google-modules:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linde linde linde approved these changes

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@williamjiuchengcai @comment-bot-dev @linde @morgante @bharathkkb