Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable disable_default_snat #625

Merged

Conversation

zioproto
Copy link
Contributor

Fixes #624
This is a proposal, because 3.35.0 is not released yet, it will need testing when the release is done.

@comment-bot-dev
Copy link

comment-bot-dev commented Aug 12, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member

bharathkkb commented Aug 12, 2020

Hi @zioproto
Thanks for the PR. We had a breaking TF release which causes some issues with our CI. Could you follow this PR terraform-google-modules/terraform-example-foundation#224 to pin our build images so the CI can run.
Edit: saw that this is a proposal, in which case we can hold off as well.

@bharathkkb
Copy link
Member

Looking at the release notes, it looks like its already present in TPGB 3.32.0 ?

@morgante morgante merged commit 19a9e9c into terraform-google-modules:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Default SNAT
4 participants