Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Explicitly specify VPC-native clusters for beta modules. #598

Merged
merged 3 commits into from Jul 10, 2020
Merged

fix: Explicitly specify VPC-native clusters for beta modules. #598

merged 3 commits into from Jul 10, 2020

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Jul 8, 2020 •
edited

Fixes #593

BREAKING CHANGE: Minimum provider version for beta modules increased to v3.29.0.

@morgante morgante requested review from bharathkkb, Jberlinsky and a team as code owners July 8, 2020 22:13
@bharathkkb
Copy link
Member

@morgante looks like I used the the safer_cluster module from the registry for the bastion host example and thats causing the failure as it is still referring to the 9.4 release.

terraform-google-kubernetes-engine/examples/safer_cluster_iap_bastion/cluster.tf

Line 19 in 1de41ef

version = "~> 9.0"

@morgante
Copy link
Contributor Author

morgante commented Jul 9, 2020

@bharathkkb Good catch, I was wondering why this was still failing.

@morgante morgante force-pushed the fix/vpc-native branch 2 times, most recently from c3ec3ce to d7923aa Compare July 9, 2020 03:39
bharathkkb
bharathkkb previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgante morgante merged commit d9f7782 into master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb left review comments

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with IpAllocationPolicy
2 participants
@morgante @bharathkkb