Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config_connector to safer variant #581

Merged
merged 1 commit into from Jun 25, 2020
Merged

add config_connector to safer variant #581

merged 1 commit into from Jun 25, 2020

Conversation

jmymy
Copy link
Contributor

@jmymy jmymy commented Jun 25, 2020

No description provided.

@jmymy jmymy marked this pull request as ready for review June 25, 2020 22:49
@jmymy jmymy requested review from bharathkkb, Jberlinsky and a team as code owners June 25, 2020 22:49
@jmymy jmymy changed the title add configconnector to safer variant add config_connector to safer variant Jun 25, 2020
morgante
morgante approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@morgante morgante merged commit 4b3f609 into terraform-google-modules:master Jun 25, 2020
@jmymy jmymy deleted the add-confg-connector-to-safer branch June 26, 2020 00:23
@zolech
Copy link

zolech commented Jan 28, 2021

Hi. Is there any possibility to merge this into private_cluster submodule?

@morgante
Copy link
Contributor

@zolech It's already available on the beta_private_cluster: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/modules/beta-private-cluster

@zolech
Copy link

zolech commented Jan 28, 2021

I know, but I am avoiding anything that has "beta" in it's name. Is there any reason that this feature is not in a "private_cluster" submodule?

@morgante
Copy link
Contributor

config_connector_config is only supported in beta: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#config_connector_config

@zolech
Copy link

zolech commented Jan 28, 2021 •
edited

Ah ok. I didn't realize that there is a second - beta provider. Thanks for the clarification. I will try to switch to beta submodule then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmymy @zolech @morgante