Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KALM config #528

Merged
merged 4 commits into from May 26, 2020
Merged

Add KALM config #528

merged 4 commits into from May 26, 2020

Conversation

c0ffeec0der
Copy link
Contributor

Add KALM config

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to bump the beta provider to 3.21.0 to get tests passing.

@c0ffeec0der
Copy link
Contributor Author

Okay, beta provider updated in /autogen/version.tf.tmpl

@bharathkkb
Copy link
Member

bharathkkb commented May 21, 2020

@c0ffeec0der you will need to update the providers in examples which use the beta-modules as well. If you do make docker_test_lint that should show you which examples are failing validation due to this.

@c0ffeec0der
Copy link
Contributor Author

I ran make docker_test_lint and it found a lot of errors (attached). But i think most is not related to the change, rather to windows character formatting. So I did some guesswork here and think the modules in examples folder get the beta version from test/setup/versions.tf . I have updated the file. Is the test on your end still failing? If you could supply the result of make docker_test_lint on your end, I'll make the changes in the code

test_lint_error.txt

@bharathkkb
Copy link
Member

Sure, here are the logs: https://gist.github.com/bharathkkb/f1298ef2629c1ce0f25f30fea3de0c71
Basically any example like ./examples/node_pool you see that has the error No provider "google-beta" plugins meet the constraint is failing because we have the required beta provider to be at least 3.21.0 but those examples are using an older version.

@c0ffeec0der
Copy link
Contributor Author

Ah okay, so I have updated the failing version in /examples

But the ones in /test/fixtures doesn't seem to specify provider version. It looks like it use the same one in /examples?

I see the second trigger of the cloud build successful. Is that the lint check? If there is still error, let me know how to fix the one in /test/fixtures, because I couldn't find the provider version explicitly mentioned in that one. Thanks

@bharathkkb
Copy link
Member

I apologize for the back and forth, we are working to surface these logs to make contributing easier 😃 And yes, the ones in fixtures don't need them as we have set in the examples.

LGTM overall. However we need to make sure that the issue mentioned here #428 does not happen. I think this was fixed in the provider but I am happy to give this a whirl and confirm.

@morgante I think int tests are failing due to the cloudbuild service account unable to copy the acm yaml from GCS. Could you PTAL?

@c0ffeec0der
Copy link
Contributor Author

No worries, always happy to help :)

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Enabling/disabling seems to updating in-place as expected.

@morgante morgante merged commit 6bf1178 into terraform-google-modules:master May 26, 2020
@bharathkkb bharathkkb mentioned this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants