Default datapath_provider to ADVANCED_DATAPATH (aka. Dataplane V2) for safer-cluster with variable for fallback

[somethingnew2-0]

First time contributor implementing #1064

Default safer-cluster to Dataplane V2 with

datapath_provider = "ADVANCED_DATAPATH"

But allow module consumers to set V1 as a fallback via a module variable, as upgrading to Dataplane V2 requires cluster re-creation.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[morgante]

Tests also need to be updated:

     ×  Command: `gcloud --project=ci-gke-f42945c6-df7a container clusters --zone=us-central1 describe safer-cluster-cluster-zl1w --format=json` cluster has the expected addon settings
     expected {"cloudRunConfig" => {"loadBalancerType" => "LOAD_BALANCER_TYPE_EXTERNAL"}, "configConnectorConfig" => {}, ...alancing" => {}, "kubernetesDashboard" => {"disabled" => true}, "networkPolicyConfig" => {"disabled" => true}} to include {"networkPolicyConfig" => {}}
     Diff:
     
     @@ -1,6 +1,9 @@
     -"cloudRunConfig" => (including {"loadBalancerType" => "LOAD_BALANCER_TYPE_EXTERNAL"}),
     +"cloudRunConfig" => {"loadBalancerType"=>"LOAD_BALANCER_TYPE_EXTERNAL"},
     +"configConnectorConfig" => {},
     +"dnsCacheConfig" => {},
     +"gcePersistentDiskCsiDriverConfig" => {"enabled"=>true},
      "horizontalPodAutoscaling" => {},
      "httpLoadBalancing" => {},
     -"kubernetesDashboard" => (including {"disabled" => true}),
     -"networkPolicyConfig" => {},
     +"kubernetesDashboard" => {"disabled"=>true},
     +"networkPolicyConfig" => {"disabled"=>true},

[morgante]

Still failing:

Profile: safer_cluster
Version: (not specified)
Target:  local://

  ×  gcloud: Google Compute Engine GKE configuration (1 failed)
     ×  Command: `gcloud --project=ci-gke-7bb763aa-8c55 container clusters --zone=us-central1 describe safer-cluster-cluster-yo5k --format=json` has network policy disabled
     
     expected: {"enabled"=>false}
          got: nil

[somethingnew2-0]

Looks like that fixed it 😄

Thanks for the help @morgante!