Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ready] [breaking] Added monitoring_config and logging_config variables to beta clusters #1028

Merged
merged 4 commits into from
Dec 16, 2021
Merged

[ready] [breaking] Added monitoring_config and logging_config variables to beta clusters #1028

merged 4 commits into from
Dec 16, 2021

Conversation

rosmo
Copy link
Contributor

@rosmo rosmo commented Oct 18, 2021 •
edited

  • Updated the provider version too
  • Also made it docker binary configurable (given all the changes with Docker Desktop etc)

Related changes: hashicorp/terraform-provider-google#10125

@rosmo rosmo requested review from bharathkkb, Jberlinsky and a team as code owners October 18, 2021 14:19
@NeckBeardPrince
Copy link

@rosmo I assume this is to allow enabling new Workloads option in Logging and Monitoring?

morgante
morgante suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/versions.tf.tmpl Show resolved Hide resolved
morgante
morgante suggested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you increased the minimum required version, versions in examples will need to be updated.

@comment-bot-dev
Copy link

comment-bot-dev commented Oct 19, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

@rosmo
Added monitoring_enabled_components and logging_enabled_components va…
1a41e47 
…riables to beta clusters

and updated provider version.
@rosmo
Copy link
Contributor Author

rosmo commented Oct 27, 2021

Since you increased the minimum required version, versions in examples will need to be updated.

I updated all the examples to the newer provider version.

morgante
morgante approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@morgante
Copy link
Contributor

This should be merged in our next breaking release.

@morgante morgante changed the title Added monitoring_config and logging_config variables to beta clusters [ready] [breaking] Added monitoring_config and logging_config variables to beta clusters Oct 27, 2021
@lukpep lukpep mentioned this pull request Nov 8, 2021
Closed
@NeckBeardPrince
Copy link

@rosmo Can you review the conflicts?

@bharathkkb
Copy link
Member

@rosmo we have an upcoming breaking release (#1086), can you resolve the conflicts?

@bharathkkb bharathkkb mentioned this pull request Dec 16, 2021
Merged
morgante
morgante approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is unrelated.

@morgante morgante merged commit 9278265 into terraform-google-modules:master Dec 16, 2021
@Nicarim
Copy link

Nicarim commented Jan 19, 2022

Did anyone get this change to work? I'm getting issue of not being able to use it at all, getting errors as in this issue: hashicorp/terraform-provider-google#10361

bharathkkb pushed a commit that referenced this pull request Jan 21, 2022
@rosmo @bharathkkb
feat: Added monitoring_enabled_components and logging_enabled_compone…
3378a9b 
…nts variables to beta clusters (#1028)
@thomas-riccardi thomas-riccardi mentioned this pull request Feb 3, 2022
Closed
@rwong2888
Copy link
Contributor

@rosmo , @morgante
Can we get monitoring_enabled_components for the other submodules? Particularly private-cluster.

@rwong2888 rwong2888 mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rosmo @NeckBeardPrince @comment-bot-dev @morgante @bharathkkb @Nicarim @rwong2888