New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom_role submodule #95

Merged

morgante merged 11 commits into master from feature/custom-role-iam

Mar 25, 2020

Contributor

kunalkg11 commented Mar 6, 2020

New Feature Additions:

Added "custom_role_iam" submodule to create a custom role at org or project level.
Added an example for the submodule.
Added a fixture to wrap around the example.
Added integration test for the "custom_role_iam" submodule for project level custom role.
Added "custom-role" test suite to .kitchen.yml
Added "custom-role-local" suite to the int.cloudbuild.yaml


          Added custom_role submodule

f7899df

kunalkg11 requested a review from morgante

March 6, 2020 17:14


          Changed count for org level custom role resource

b4222ef

kunalkg11 requested a review from bharathkkb

March 12, 2020 23:05

bharathkkb reviewed

View reviewed changes

examples/custom_role/main.tf Outdated Show resolved Hide resolved

bharathkkb reviewed

View reviewed changes

examples/custom_role/main.tf Outdated Show resolved Hide resolved

bharathkkb reviewed

View reviewed changes

modules/custom_role_iam/README.md Outdated Show resolved Hide resolved

bharathkkb reviewed

View reviewed changes

test/fixtures/custom-role/main.tf Outdated Show resolved Hide resolved

bharathkkb reviewed

View reviewed changes

modules/custom_role_iam/variables.tf Show resolved Hide resolved

bharathkkb reviewed

View reviewed changes

modules/custom_role_iam/variables.tf Show resolved Hide resolved


          Addressing PR comments

e33e2ef

morgante suggested changes

View reviewed changes

examples/custom_role/main.tf Outdated Show resolved Hide resolved

examples/custom_role/main.tf Outdated Show resolved Hide resolved

modules/custom_role_iam/README.md Outdated Show resolved Hide resolved

modules/custom_role_iam/main.tf Outdated Show resolved Hide resolved

modules/custom_role_iam/outputs.tf Outdated Show resolved Hide resolved

modules/custom_role_iam/variables.tf Outdated Show resolved Hide resolved

modules/custom_role_iam/variables.tf Outdated Show resolved Hide resolved

Kunal Kumar Gupta added 2 commits

March 17, 2020 18:39


          Addressing PR comments, added org example and integration test

f389477


          Added Org Role Admin permission to project SA in test/setup.

6fdd8b1

morgante suggested changes

View reviewed changes

examples/custom_role_org/outputs.tf Outdated Show resolved Hide resolved

examples/custom_role_org/variables.tf Outdated Show resolved Hide resolved

examples/custom_role_project/main.tf Outdated Show resolved Hide resolved

examples/custom_role_project/outputs.tf Outdated Show resolved Hide resolved

examples/custom_role_project/variables.tf Outdated Show resolved Hide resolved

modules/custom_role_iam/README.md Show resolved Hide resolved

modules/custom_role_iam/README.md Outdated Show resolved Hide resolved

modules/custom_role_iam/variables.tf Show resolved Hide resolved

Kunal Kumar Gupta added 4 commits

March 17, 2020 21:17


          Addressing PR comments

0f52f9c


          Fixed integration tests and lint issues


          Added random bit for role_id for org level custom role

8ad998c


          Added registry in README

67cbd4a

morgante suggested changes

View reviewed changes

modules/custom_role_iam/variables.tf Show resolved Hide resolved


          Setting description default

7cd9cd8

morgante suggested changes

View reviewed changes

modules/custom_role_iam/README.md Outdated Show resolved Hide resolved

modules/custom_role_iam/README.md Outdated Show resolved Hide resolved


          Fixed README for module

4d0a333

morgante approved these changes

View reviewed changes

morgante merged commit 18cbbf1 into master

Contributor

morgante commented Mar 25, 2020

@kunalkg11 The description variable isn't used at all / isn't set on the resource: https://github.com/terraform-google-modules/terraform-google-iam/blob/master/modules/custom_role_iam/main.tf

Please open a follow-up PR which fixes this and add appropriate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment