allow setting storage.admin and storage.hmacKeyAdmin roles #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Any chance of getting this reviewed? Thanks! |
|
ping :) |
bharathkkb
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
LGTM
We should consider revamping the root interface now that we have module for_each to support a single bucket and any arbitrary IAM roles, so we don't have a bool flag, map for each bucket and list for all buckets to collapse all IAM varriables.
Tracking #104
|
can this be merged? I guess someone would have to trigger the CI job first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18
this adds changes from #22 which were not included in #86
also: