Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves simple bucket lifecycle #76

Merged
merged 2 commits into from Aug 17, 2020
Merged

Improves simple bucket lifecycle #76

merged 2 commits into from Aug 17, 2020
+2 −1

Conversation

rjmco
Copy link
Contributor

@rjmco rjmco commented Aug 17, 2020

  • Fixes simple_bucket lifecycle created_before field lookup
  • Adds is_live field to simple_bucket lifecycle

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit a16305d into terraform-google-modules:master Aug 17, 2020
@rjmco rjmco deleted the rjmco_improve_simple_bucket_lifecycle branch August 18, 2020 08:45
@darkn3rd
Copy link

darkn3rd commented Feb 4, 2021

@rjmco @morgante This breaks with 3.x provider:

  on .terraform/modules/gcs.gcs/modules/simple_bucket/main.tf line 55, in resource "google_storage_bucket" "bucket":
  55:         is_live               = lookup(lifecycle_rule.value.condition, "is_live", null)

https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_3_upgrade#is_live-is-now-removed

@darkn3rd darkn3rd mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rjmco @comment-bot-dev @darkn3rd @morgante