add support for cors and website blocks #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
approved these changes
May 26, 2020
pkatsovich
changed the title
morgante
suggested changes
May 26, 2020
morgante
approved these changes
May 26, 2020
|
@pkatsovich Make sure to also regenerate the docs. |
|
@morgante 😅, ofcourse.. updated. |
morgante
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
corsandwebsiteattribute blocks.These are needed for managing buckets to be used as static sites.
https://www.terraform.io/docs/providers/google/r/storage_bucket.html#example-usage-creating-a-private-bucket-in-standard-storage-in-the-eu-region-bucket-configured-as-static-website-and-cors-configurations
I had to define the variables as
type = anydue to this issue: hashicorp/terraform#19898I've also updated theprefixvariable to have a default of an empty string. Which should be a nicer experience then having to explicitly set the attribute to an empty string as part of module inputs if you don't want a prefix and location info pre-pended to the bucket name.Should make experiences like this a little cleaner: #12