Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/top folders #59

Merged
merged 2 commits into from
May 22, 2020
Merged

Feature/top folders #59

merged 2 commits into from
May 22, 2020

Conversation

ChandranshuRao14
Copy link
Contributor

Fixes #46

Feature: Create top level folders in GCS buckets
Usage: var.folders is a map of lowercase unprefixed name => list of top level folder objects.

  folders = {
    "two" = ["dev", "prod"]
  }

morgante
morgante approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and including tests. Looks great!

@morgante morgante merged commit 0fa0689 into terraform-google-modules:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Allow creation of top level folders in bucket
2 participants
@ChandranshuRao14 @morgante