Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Nat Module always changed value to default when tcp_established_idle_timeout_sec was set as number #52

Open
tacumai opened this issue Jun 3, 2021 · 1 comment
Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work

Comments

@tacumai
Copy link

tacumai commented Jun 3, 2021

Hi ✋
Hire is Cloud Nat Module's property I'm mentioning

  • tcp_established_idle_timeout_sec
  • icmp_idle_timeout_sec
  • min_ports_per_vm
  • tcp_transitory_idle_timeout_sec
  • udp_idle_timeout_sec

these properties has string type but value is number .
It confused me.
And we can run plan and apply if the properties were set as number like

variable "nat" {
     name                               = string
     nat_ip_allocate_option             = string
     source_subnetwork_ip_ranges_to_nat = string
-    icmp_idle_timeout_sec              = number
-    min_ports_per_vm                   = number
     tcp_established_idle_timeout_sec   = string
-    tcp_transitory_idle_timeout_sec    = number
-    udp_idle_timeout_sec               = number

especially, tcp_established_idle_timeout_sec is back to default value 1200 when I set any timeout count like 60 as number.

Requests

I suggest that the properties can be also set as number or when users set as number and run terraform plan , generate an error.

Thanks for reading.

@morgante
Copy link
Contributor

morgante commented Jun 3, 2021

Feel free to open a PR for changing this.

@morgante morgante added enhancement New feature or request P4 low priority issues triaged Scoped and ready for work labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants