Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform to 0.13.7 #490

Merged

Conversation

vovinacci
Copy link
Contributor

@vovinacci vovinacci commented Jun 17, 2021

This PR sets the terraform version to 0.13.7 in the code and and in README references.

Main reasoning behind this PR is that 0.13.7 is the latest version (and most likely the last one in 0.13) and it's not easy to get 0.13.6 as a package. So, it helps with local development a lot as it won't require to resolve state snapshot was created by Terraform v0.13.7, which is newer than current v0.13.6 error.

@vovinacci vovinacci requested review from bharathkkb, rjerrems and a team as code owners June 17, 2021 05:28
@vovinacci vovinacci changed the title Upgrade terraform to 0.13.7 Update terraform to 0.13.7 Jun 17, 2021
@vovinacci
Copy link
Contributor Author

@daniel-cit @bharathkkb @rjerrems Integration tests failed, could you please advise what went wrong as I don't have access to Cloud Build project. Thanks and much appreciated!

@rjerrems
Copy link
Collaborator

@vovinacci - I have taken a look at it looks like one of the steps is failing (across a number of PRs). Worth noting that the test runner is currently on 0.13.5 - not sure if we have plans to update @bharathkkb ?

@bharathkkb
Copy link
Member

@rjerrems 0.13.7 was a backport due to https://discuss.hashicorp.com/t/terraform-updates-for-hcsec-2021-12/23570 and we have not cut a backport test container image as we were already at 0.15.x.

I don't expect the runner to complain since we should only have >0.13 constraints in config.

* master:
  docs: Remove redundant header from Jenkins bootstrap (terraform-google-modules#491)
@vovinacci
Copy link
Contributor Author

@rjerrems Many thanks for the fix, all checks are back to green.

@bharathkkb Having 0.15 would be very nice. Any plans to add it as a default? I may imagine that some modules may not support it yet, but you may know all the details better that anyone else :)

Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit a9150a7 into terraform-google-modules:master Jun 23, 2021
@bharathkkb
Copy link
Member

@vovinacci we are hoping to update all modules upstream to support 1.0 soon so this would also support 1.0. We would not require 1.0 in requirements but will switch our CI to do testing with 1.0. I expect current release to be mostly compatible with minor changes (deprecated list() fn, sensitive values being set)

@vovinacci vovinacci deleted the upgrade-terraform-0.13.7 branch June 23, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants