Update README.md re: terraform.example.tfvars #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md to match Jenkins. Change from copy `terraform.example.tfvars` to rename to avoid creating multiple input variable definition files.
matt-declarativecloud
requested review from
bharathkkb,
rjerrems and
a team
as code owners
Change sequence to run `terraform init` immediately after `cp backend.tf.example backend.tf`. Current sequence has `terraform output terraform_service_account` immediately after `cp backend.tf.example backend.tf` which generates `Backend reinitialization required. Please run "terraform init".`
Change 'from previous step' to 'from Terraform's state' to make wording less dependent on precise order of steps
rjerrems
reviewed
May 3, 2021
rjerrems
reviewed
May 3, 2021
rjerrems
reviewed
May 3, 2021
There was a problem hiding this comment.
Thanks for the PR @matt-declarativecloud - I have left a couple of comments.
Add mv terraform.example.tfvars terraform.tfvars for easy copy/paste
Correct spacing formatting error in my last commit
rjerrems
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md to match Jenkins. Change from copy
terraform.example.tfvarsto rename to avoid creating multiple input variable definition files.