Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add impersonate to gcloud builds submit command in infra-pipeline module #458

Merged
merged 1 commit into from
Apr 26, 2021
Merged

add impersonate to gcloud builds submit command in infra-pipeline module #458

merged 1 commit into from
Apr 26, 2021

Conversation

daniel-cit
Copy link
Contributor

Fixes #452

@daniel-cit daniel-cit marked this pull request as ready for review April 26, 2021 19:06
@daniel-cit daniel-cit requested review from bharathkkb, rjerrems and a team as code owners April 26, 2021 19:06
rjerrems
rjerrems approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit 1d3fbf8 into terraform-google-modules:master Apr 26, 2021
@daniel-cit daniel-cit deleted the fix-missing-impersonate-issue branch September 2, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4-projects Cloud Build Step 13 v fails - Terraform not impersonating Service Account
2 participants
@daniel-cit @rjerrems