fix: add infra pipeline CB SA role test #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the test for the editor role on the Cloud Build service account and also removes the indexing from both service account tests.
chris-ingrisani
requested review from
bharathkkb,
rjerrems and
a team
as code owners
chris-ingrisani
changed the title
|
@bharathkkb I couldn't get the test environment to spin up today, I kept getting billing errors, but this was the proposed change: |
|
@chris-ingrisani I think this should be fine for now, we can refactor if it breaks |
bharathkkb
changed the title
bharathkkb
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test for the editor role on the Cloud Build service account and also removes the indexing from both service account tests. Rebased on main according to PR #394.