Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bootstrap example #407

Merged
merged 2 commits into from
Apr 8, 2021
Merged

update bootstrap example #407

merged 2 commits into from
Apr 8, 2021

Conversation

z-shah
Copy link
Contributor

@z-shah z-shah commented Apr 7, 2021

  • Update project_id and state_bucket_name in cloudbuild and seed module examples to follow whitepaper standards
  • Update documentation
  • Update tests to avoid build conflicts

@z-shah z-shah requested review from bharathkkb, rjerrems and a team as code owners April 7, 2021 06:34
rjerrems
rjerrems approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems requested a review from daniel-cit April 7, 2021 23:54
@rjerrems
Copy link
Collaborator

rjerrems commented Apr 7, 2021

@daniel-cit @bharathkkb PTAL when you have a chance. We introduced a bucket_prefix variable with a default value so we do not need to include the project prefix in the bucket name.

@bharathkkb bharathkkb merged commit 03bd05a into terraform-google-modules:master Apr 8, 2021
@rjerrems rjerrems mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@bharathkkb bharathkkb bharathkkb approved these changes

@daniel-cit daniel-cit Awaiting requested review from daniel-cit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@z-shah @rjerrems @bharathkkb