Update terraform-validator version, instructions and CMEK bucket #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
2021-03-22
This PR also replaces the module used in the creation of the Google Cloud Storage bucket in the CMEK examples in the 4-projects environments.
From the main module
terraform-example-foundation/4-projects/business_unit_1/production/example_storage_cmek.tf
Line 69 in 137a379
to the simple bucket module
This is necessary because the way the main module construct the bucket attribute in the context of a random bucket name
makes the after state of the bucket to be known only after apply which make terraform-validator crash.
Running the terraform-validator version in the master branch
which has the bugfix for the crash, terraform-validator rises a false positive.
both issues, the crash and the false positive do not happen when using the simple bucket module
This change can be made because the CMEK creates a single bucket.