Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds step 5-app-infra #382

Merged
merged 32 commits into from
Apr 8, 2021
Merged

Adds step 5-app-infra #382

merged 32 commits into from
Apr 8, 2021

Conversation

amandakarina
Copy link
Contributor

This pull request adds an example of GCE creation

@amandakarina amandakarina changed the base branch from master to develop March 19, 2021 17:22
@amandakarina amandakarina changed the title Adds step 5-app-infra [WIP] Adds step 5-app-infra Mar 19, 2021
bharathkkb
bharathkkb reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to start. Thanks for working on this

5-app-infra/modules/env_base/main.tf Show resolved Hide resolved
5-app-infra/modules/env_base/main.tf Outdated Show resolved Hide resolved
5-app-infra/common.example.tfvars Outdated Show resolved Hide resolved
5-app-infra/business_unit_1/production/providers.tf Outdated Show resolved Hide resolved
@amandakarina amandakarina changed the title [WIP] Adds step 5-app-infra Adds step 5-app-infra Mar 29, 2021
@amandakarina amandakarina marked this pull request as ready for review March 29, 2021 15:34
@amandakarina amandakarina requested review from rjerrems and a team as code owners March 29, 2021 15:34
bharathkkb
bharathkkb reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some comments around docs

5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/common.auto.example.tfvars Outdated Show resolved Hide resolved
5-app-infra/README.md Show resolved Hide resolved
5-app-infra/README.md Show resolved Hide resolved
5-app-infra/business_unit_1/development/variables.tf Outdated Show resolved Hide resolved
5-app-infra/business_unit_1/development/main.tf Outdated Show resolved Hide resolved
@bharathkkb
Copy link
Member

we recently merged develop into main, please switch base to main branch and rebase

@amandakarina amandakarina changed the base branch from develop to master March 31, 2021 17:47
@amandakarina amandakarina changed the base branch from master to develop March 31, 2021 17:47
amandakarina and others added 17 commits April 1, 2021 10:08
@amandakarina
Adds environment base module to create gce instance
5f9783a
@amandakarina
Adds development environment for business unit 1 example
e443367
@amandakarina
Adds empty README for step 5
af5ba22
@amandakarina
Adds non-prodcution environment for bu1 example
a720d71
@amandakarina
Adds production environment for bu1 example
79a7871
@amandakarina
Adds common.tfvars example and symbolic links
d4cc9ba
@amandakarina
Adds fixture for 5-app-infra
19ff981
@amandakarina
Adds outputs for test, adds initial validation of gce instance
046d58e
@amandakarina
Updates README
bc15bea
@daniel-cit @amandakarina
fix linting on readme
34ae966
@amandakarina
Adds step on build, adds number of instances as variable
733fcd8
@amandakarina
Adds tmp_plan folder on gitignore, pins version of modules
ea21ab6
@amandakarina
Changes impersionate configuration to native
1c6741a
@amandakarina
Adds name of instances in outputs
0f5ea79
@amandakarina
Fixes symbolic links
e616429
@amandakarina
Fixes fixture for test
7fa7a1f
@amandakarina
Adds example tfvars
6d2bc90
@amandakarina amandakarina changed the base branch from develop to master April 1, 2021 13:19
bharathkkb
bharathkkb requested changes Apr 2, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amandakarina we had a rename of the project, could you swap all old references if any
#404

5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
5-app-infra/README.md Outdated Show resolved Hide resolved
daniel-cit and others added 2 commits April 7, 2021 21:30
@daniel-cit @bharathkkb
Apply suggestions from code review to step 5 README
b59bc98 
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@daniel-cit
fix lint issues
b31529e
@bharathkkb bharathkkb merged commit fd5329c into terraform-google-modules:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@daniel-cit daniel-cit Awaiting requested review from daniel-cit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amandakarina @bharathkkb @daniel-cit