Bugfix/fix 4-projects issues

[renato-rudnicki]

This PR contains the fix for the following issues:

• 350 - common.auto.tfvars link pointing to an example file
• 351 - Missing backend.tf file from shared folder
• 352 - access_context_manager_policy_id but a value was found in file "common.auto.tfvars"
• 353 - billingbudgets.googleapis.com is not enabled for infra-cicd deployment
• 365 - MIssing app_infra_pipeline_cloudbuild_sa variable on environments tfvars examples in step 4-projects

[bharathkkb]

/gcbrun

[bharathkkb]

Thanks for the PR @renato-rudnicki
Can you update the readme with the required steps as well
https://github.com/terraform-google-modules/terraform-example-foundation/tree/develop/4-projects#setup-to-run-via-cloud-build

[renato-rudnicki]

Increasing lifetime field in providers.tf from 900s to 1200s due timeout during build tests.

[bharathkkb]

/gcbrun

[bharathkkb]

Let's keep this uniform here and throughout

Suggested change

	lifetime = "600s"
	lifetime = "1200s"

[renato-rudnicki]

Updating lifetime to 1200ms in shared/providers.tf in Business Unit 1 and 2.

data "google_service_account_access_token" "default" {
  provider               = google.impersonate
  target_service_account = local.tf_sa
  scopes                 = ["userinfo-email", "cloud-platform"]
  lifetime               = "1200s"
}

[daniel-cit]

build 4b01ba07-eef9-4fc3-a2d0-bc5409b92aef for the default mode failed in this test:

Profile: tests from /workspace/test/integration/projects (tests from .workspace.test.integration.projects)
Version: (not specified)
Target:  local://
  ×  gcloud-projects: gcloud step 4-projects tests (1 failed)
     ×  Command: `gcloud access-context-manager perimeters describe sp_d_shared_restricted_default_perimeter_3dbe --policy <REDACTED> --format=json` Access Context Manager perimeter sp_d_shared_restricted_default_perimeter_3dbe should include tst-bu1-d-sample-restrict-dbd2 project
     expected ["projects/136738339700", "projects/759250792841"] to include "projects/580269401305"

checking the previous steps, the reason for project 580269401305 not being in the perimeter was a concurrente update of the service perimeter by the two dev projects, bu1 and bu2.

it is necessary to add an explicitly dependency between the modules in the fixture for step 4-projects
https://github.com/terraform-google-modules/terraform-example-foundation/blob/develop/test/fixtures/projects/main.tf

so that the bu2 projects wait for their pair in bu1 to run before updating the service perimeter.

This error does not happens in the cloud build deploy because the shell script serializes the execution of the two projects for the same environment.

[bharathkkb]

@daniel-cit Thanks for investigating, I do see the converge worked fine Creation complete after 1s [id=accessPolicies/x/servicePerimeters/sp_d_shared_restricted_default_perimeter_3dbe/projects/580269401305]

For serializing you may have to do something like 85dec25

[daniel-cit]

LGTM