Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4-projects GCS CMEK module #346

Merged
merged 19 commits into from
Mar 9, 2021
Merged

4-projects GCS CMEK module #346

merged 19 commits into from
Mar 9, 2021

Conversation

rutalreja-deloitte
Copy link
Contributor

CMEK Module first review submission
Tests to follows in next PR

@rutalreja-deloitte rutalreja-deloitte marked this pull request as draft February 22, 2021 20:36
@rutalreja-deloitte
Copy link
Contributor Author

Need to investigate why Checks fail, would love a draft review and any comments.

@rutalreja-deloitte rutalreja-deloitte marked this pull request as ready for review February 22, 2021 22:42
bharathkkb
bharathkkb requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rutalreja-deloitte

4-projects/business_unit_1/development/outputs.tf Outdated Show resolved Hide resolved
4-projects/business_unit_1/development/example_storage_cmek.tf Outdated Show resolved Hide resolved
4-projects/business_unit_1/development/example_storage_cmek.tf Outdated Show resolved Hide resolved
4-projects/business_unit_1/development/example_storage_cmek.tf Outdated Show resolved Hide resolved
bharathkkb
bharathkkb reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the integration tests are failing at 4-projects Could you take a look?
Also looks like there is a merge conflict, you can rebase on develop.

@rutalreja-deloitte rutalreja-deloitte marked this pull request as draft February 24, 2021 23:41
@rutalreja-deloitte rutalreja-deloitte marked this pull request as ready for review February 25, 2021 08:03
@rutalreja-deloitte rutalreja-deloitte marked this pull request as draft March 1, 2021 15:20
@bharathkkb bharathkkb mentioned this pull request Mar 2, 2021
Closed
3 tasks
bharathkkb
bharathkkb approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other items tracked in #356 for subsequent PRs
/cc @rjerrems

@rutalreja-deloitte rutalreja-deloitte marked this pull request as ready for review March 2, 2021 08:28
@rutalreja-deloitte
Copy link
Contributor Author

@bharathkkb CMEK - MultiEnv 3a235ac was failing; terraform was trying to create the GCS bucket before the IAM policy for Encrypter/Decrypter was set on the KMS Key.
This is because the implicit dependency was only to the Key being generated, not the other stuff like IAM bindings
encryption_key_names = zipmap([random_string.bucket_name.result], values(module.kms.keys))
A quick fix is adding an explicit dependency on the entire kms module as supported by Module level dependency in Terraform 0.13+ done in d9c5b32
If you see any better way, please let me know, and I will update, else this is ready for Merge

@bharathkkb
Copy link
Member

Thanks for investigating @rutalreja-deloitte

@bharathkkb bharathkkb merged commit dbd4c73 into terraform-google-modules:develop Mar 9, 2021
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@rutalreja-deloitte @bharathkkb
feat: 4-projects GCS CMEK example (#346)
0f2565f 
* 4-projects GCS CMEK module

* 4-projects GCS CMEK module - Quick Fix

* 4-projects GCS CMEK module - Lint

* 4-projects GCS CMEK module - Validate

* 4-projects GCS CMEK module - README

* 4-projects GCS CMEK module - README2 + KMS version

* 4-projects GCS CMEK module - Bug Fix 2

* 4-projects GCS CMEK module - Requested Changes

* 4-projects GCS CMEK module - Bug Fix 3

* 4-projects GCS CMEK module - Key Destroy Support

* 4-projects GCS CMEK module - Key Map Update

* 4-projects GCS CMEK module - Variables

* 4-projects GCS CMEK module - Final

* CMEK - MultiEnv

* CMEK Multi-Env Explicit Depends on
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@rutalreja-deloitte @bharathkkb
feat: 4-projects GCS CMEK example (#346)
43858f1 
* 4-projects GCS CMEK module

* 4-projects GCS CMEK module - Quick Fix

* 4-projects GCS CMEK module - Lint

* 4-projects GCS CMEK module - Validate

* 4-projects GCS CMEK module - README

* 4-projects GCS CMEK module - README2 + KMS version

* 4-projects GCS CMEK module - Bug Fix 2

* 4-projects GCS CMEK module - Requested Changes

* 4-projects GCS CMEK module - Bug Fix 3

* 4-projects GCS CMEK module - Key Destroy Support

* 4-projects GCS CMEK module - Key Map Update

* 4-projects GCS CMEK module - Variables

* 4-projects GCS CMEK module - Final

* CMEK - MultiEnv

* CMEK Multi-Env Explicit Depends on
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@rutalreja-deloitte @bharathkkb
feat: 4-projects GCS CMEK example (#346)
b1b8340 
* 4-projects GCS CMEK module

* 4-projects GCS CMEK module - Quick Fix

* 4-projects GCS CMEK module - Lint

* 4-projects GCS CMEK module - Validate

* 4-projects GCS CMEK module - README

* 4-projects GCS CMEK module - README2 + KMS version

* 4-projects GCS CMEK module - Bug Fix 2

* 4-projects GCS CMEK module - Requested Changes

* 4-projects GCS CMEK module - Bug Fix 3

* 4-projects GCS CMEK module - Key Destroy Support

* 4-projects GCS CMEK module - Key Map Update

* 4-projects GCS CMEK module - Variables

* 4-projects GCS CMEK module - Final

* CMEK - MultiEnv

* CMEK Multi-Env Explicit Depends on
bharathkkb pushed a commit that referenced this pull request Mar 31, 2021
@rutalreja-deloitte @bharathkkb
feat: 4-projects GCS CMEK example (#346)
d74ff33 
* 4-projects GCS CMEK module

* 4-projects GCS CMEK module - Quick Fix

* 4-projects GCS CMEK module - Lint

* 4-projects GCS CMEK module - Validate

* 4-projects GCS CMEK module - README

* 4-projects GCS CMEK module - README2 + KMS version

* 4-projects GCS CMEK module - Bug Fix 2

* 4-projects GCS CMEK module - Requested Changes

* 4-projects GCS CMEK module - Bug Fix 3

* 4-projects GCS CMEK module - Key Destroy Support

* 4-projects GCS CMEK module - Key Map Update

* 4-projects GCS CMEK module - Variables

* 4-projects GCS CMEK module - Final

* CMEK - MultiEnv

* CMEK Multi-Env Explicit Depends on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rutalreja-deloitte @bharathkkb