Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: example-foundations test modes #309

Merged
merged 4 commits into from
Dec 17, 2020
Merged

feat: example-foundations test modes #309

merged 4 commits into from
Dec 17, 2020

Conversation

bharathkkb
Copy link
Member

  • enables tests for each example-foundations mode

x-ref: GoogleCloudPlatform/cloud-foundation-toolkit#852

@bharathkkb bharathkkb requested review from rjerrems and a team as code owners December 17, 2020 03:18
Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit 81a6c07 into develop Dec 17, 2020
@bharathkkb bharathkkb deleted the add-test-modes branch December 17, 2020 18:52
bharathkkb added a commit that referenced this pull request Mar 30, 2021
* feat: example-foundations test modes

* fix bundle, fix type error

* add domain TF_VAR

* bump cred life
bharathkkb added a commit that referenced this pull request Mar 30, 2021
* feat: example-foundations test modes

* fix bundle, fix type error

* add domain TF_VAR

* bump cred life
bharathkkb added a commit that referenced this pull request Mar 30, 2021
* feat: example-foundations test modes

* fix bundle, fix type error

* add domain TF_VAR

* bump cred life
bharathkkb added a commit that referenced this pull request Mar 31, 2021
* feat: example-foundations test modes

* fix bundle, fix type error

* add domain TF_VAR

* bump cred life
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants