Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub And Spoke architecture #298

Merged
merged 20 commits into from
Jan 20, 2021
Merged

Hub And Spoke architecture #298

merged 20 commits into from
Jan 20, 2021

Conversation

averbuks
Copy link
Member

@averbuks averbuks commented Dec 4, 2020

… #297

@averbuks averbuks requested review from bharathkkb, rjerrems and a team as code owners December 4, 2020 06:59
@averbuks averbuks changed the title Change Shared VPC project names if hub_and_spoke architecture enabled… [WIP] Change Shared VPC project names if hub_and_spoke architecture enabled… Dec 4, 2020
bharathkkb
bharathkkb reviewed Dec 16, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @averbuks
Overall LGTM, just some minor questions.
/cc @rjerrems @daniel-cit @amandakarina

2-environments/terraform.example.tfvars Outdated Show resolved Hide resolved
3-networks/modules/restricted_shared_vpc/main.tf Outdated Show resolved Hide resolved
3-networks/modules/base_shared_vpc/main.tf Outdated Show resolved Hide resolved
3-networks/envs/shared/net-hubs.tf Show resolved Hide resolved
3-networks/envs/shared/net-hubs.tf Show resolved Hide resolved
@bharathkkb
Copy link
Member

@averbuks I have added the tests as we discussed via #309 but we can add tests for networks in a separate PR

@averbuks averbuks changed the title [WIP] Change Shared VPC project names if hub_and_spoke architecture enabled… Change Shared VPC project names if hub_and_spoke architecture enabled… Jan 15, 2021
@averbuks averbuks changed the title Change Shared VPC project names if hub_and_spoke architecture enabled… Hub And Spoke architecture Jan 15, 2021
@rjerrems rjerrems mentioned this pull request Jan 19, 2021
Merged
bharathkkb
bharathkkb approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @rjerrems

@rjerrems rjerrems merged commit b7b5fa2 into develop Jan 20, 2021
@averbuks averbuks deleted the hub-and-spoke-peering branch January 20, 2021 09:31
@drebes drebes mentioned this pull request Mar 4, 2021
Merged
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@averbuks @bharathkkb
feat: Add hub and spoke network architecture (#298)
2c3f0a9
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@averbuks @bharathkkb
feat: Add hub and spoke network architecture (#298)
e80f4ba
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@averbuks @bharathkkb
feat: Add hub and spoke network architecture (#298)
79c93b7
bharathkkb pushed a commit that referenced this pull request Mar 31, 2021
@averbuks @bharathkkb
feat: Add hub and spoke network architecture (#298)
d9468db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drebes drebes drebes left review comments

@gaspar-chilingarov gaspar-chilingarov gaspar-chilingarov left review comments

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@averbuks @bharathkkb @drebes @gaspar-chilingarov @rjerrems