Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds prefix to projects and folder name #289

Conversation

amandakarina
Copy link
Contributor

@amandakarina amandakarina commented Nov 16, 2020

Hey folks,

This pull request closes #270 issue and closes #275 issue.

Could you, please, take a look?

Thanks!

@amandakarina amandakarina changed the title Adds prefix to projects name Adds prefix to projects and folder name Nov 17, 2020
@daniel-cit
Copy link
Contributor

When creating a project, setting the variable to empty:

project_prefix       = ""

will result in the error: Project ID can have lowercase letters, digits or hyphens and must start with a lowercase letter.

should we add a warning in the variable description saying that the value must not be empty ?

OR do we need to write some logic around it?

@amandakarina @bharathkkb

@bharathkkb
Copy link
Member

bharathkkb commented Nov 17, 2020

@daniel-cit I think its okay to keep it as is. The error surfaced is clear, easy to recover from and we do define a default. Perhaps it does make sense to add some language in the variable description, so that its clear in the docs.

@amandakarina amandakarina marked this pull request as ready for review November 18, 2020 15:54
@amandakarina amandakarina requested review from rjerrems and a team as code owners November 18, 2020 15:54
@bharathkkb
Copy link
Member

@amandakarina looking at the build output, it seems like in 4-projects we are still using prj for testing. Could PTAL

@amandakarina
Copy link
Contributor Author

amandakarina commented Nov 20, 2020

@amandakarina looking at the build output, it seems like in 4-projects we are still using prj for testing. Could PTAL

Thanks @bharathkkb! It's fixed!

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @rjerrems

@bharathkkb bharathkkb changed the title Adds prefix to projects and folder name feat: Adds prefix to projects and folder name Nov 23, 2020
@rjerrems rjerrems merged commit be37c8f into terraform-google-modules:develop Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move folder prefix to variable Add global prefix for created projects
4 participants