-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds prefix to projects and folder name #289
feat: Adds prefix to projects and folder name #289
Conversation
When creating a project, setting the variable to empty:
will result in the error: Project ID can have lowercase letters, digits or hyphens and must start with a lowercase letter. should we add a warning in the variable description saying that the value must not be empty ? OR do we need to write some logic around it? |
@daniel-cit I think its okay to keep it as is. The error surfaced is clear, easy to recover from and we do define a default. Perhaps it does make sense to add some language in the variable description, so that its clear in the docs. |
@amandakarina looking at the build output, it seems like in 4-projects we are still using |
Thanks @bharathkkb! It's fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @rjerrems
Hey folks,
This pull request closes #270 issue and closes #275 issue.
Could you, please, take a look?
Thanks!