New org policies #283
Merged
New org policies #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Nov 5, 2020
| @@ -49,6 +49,18 @@ variable "domains_to_allow" { | |||
| type = list(string) | |||
| } | |||
|
|
|||
| variable "enable_shielded_vm_policy" { | |||
There was a problem hiding this comment.
@daniel-cit can we document the caveats for enabling each of these as well (i.e GKE issue with os login and dataflow/composer with Shielded VMs) so that the user is aware.
There was a problem hiding this comment.
I think its best to link to public docs as @daniel-cit has done, so that they can be the source of truth for any limitations
There was a problem hiding this comment.
(we should try to get docs updated where they are lacking)
|
So the plan is turn these on by default now? We should have some documentation for how to add exceptions to the policy for workloads that don't work well with these policies I think before we make it the default |
|
@rjerrems off by default and +1 for docs. |
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
bharathkkb
pushed a commit
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new org policies:
with a toggle for each one