Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make BigQuery log destinations to be partitioned #277

Merged
merged 2 commits into from
Nov 1, 2020
Merged

feat: Make BigQuery log destinations to be partitioned #277

merged 2 commits into from
Nov 1, 2020

Conversation

vovinacci
Copy link
Contributor

Closes #273

@vovinacci
Copy link
Contributor Author

Integration tests are failing, but I don't have access to check what is failing exactly.

@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb bharathkkb changed the base branch from master to develop October 30, 2020 16:55
@bharathkkb bharathkkb changed the title Make BigQuery log destinations to be partitioned feat: Make BigQuery log destinations to be partitioned Oct 30, 2020
bharathkkb
bharathkkb approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vovinacci!
/cc @rjerrems @mikelaramie

@rjerrems rjerrems merged commit b791931 into terraform-google-modules:develop Nov 1, 2020
@vovinacci vovinacci deleted the bq-partitioned-tables branch November 2, 2020 07:59
@bharathkkb bharathkkb mentioned this pull request Feb 8, 2021
Closed
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@vovinacci @bharathkkb
feat: Make BigQuery log destinations partitioned (#277)
973df4c
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@vovinacci @bharathkkb
feat: Make BigQuery log destinations partitioned (#277)
f46df31
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
@vovinacci @bharathkkb
feat: Make BigQuery log destinations partitioned (#277)
2edcbab
bharathkkb pushed a commit that referenced this pull request Mar 31, 2021
@vovinacci @bharathkkb
feat: Make BigQuery log destinations partitioned (#277)
f40c5fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert BQ log destinations are configured to be partitioned
3 participants
@vovinacci @bharathkkb @rjerrems