Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates for TF 0.13 #268

Merged
merged 7 commits into from
Oct 29, 2020
Merged

feat: Updates for TF 0.13 #268

merged 7 commits into from
Oct 29, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Oct 20, 2020

fixes #238 #226

  • Bumped versions across modules where necessary for TF0.13 compat
  • Updated CI images

Todo:

@bharathkkb bharathkkb requested review from rjerrems and a team as code owners October 20, 2020 00:18
@daniel-cit
Copy link
Contributor

The Makefile also has a reference to the developer tools image,

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0

but using version 0 which today is equivalent to 0.13, 0.13.22,
which makes a make docker_test_lint, with a new developer tools image download, fails in the master branch with:

Error: Unsupported Terraform Core version

  on .terraform/modules/project/terraform-google-project-factory-8.0.1/modules/project_services/versions.tf line 18, in terraform:
  18:   required_version = "~> 0.12.6"

@bharathkkb
Copy link
Member Author

@daniel-cit yeah I lock it to latest 0.12.x in this PR #250

@bharathkkb bharathkkb changed the title [WIP] test TF 0.13 feat: Updates for TF 0.13 Oct 27, 2020
@bharathkkb
Copy link
Member Author

@rjerrems this is ready for review

@@ -15,5 +15,5 @@
*/

terraform {
required_version = "~> 0.12.6"
required_version = ">=0.13, <0.14"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it might be worthwhile continuing to support terraform > 0.12.6 until we start using terraform 0.13 features?

@rjerrems
Copy link
Collaborator

Overall LGTM, only thing is whether or not we should continue supporting > 0.12.6 for the time being given most of the users of the foundation will be on those versions right now. I'm open to either way, let me know what you think

@bharathkkb
Copy link
Member Author

@rjerrems I was debating this as well. The only reason I kept it >=0.13 is because our next item is to try conditional modules for jenkins/CB

@rjerrems
Copy link
Collaborator

Perhaps we can do the development on the develop branch, then cut a release once we have adding 0.13 support / conditional modules?

@bharathkkb bharathkkb changed the base branch from master to develop October 27, 2020 21:50
@bharathkkb
Copy link
Member Author

@rjerrems sgtm, I have switched the base :)

Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit d7f1011 into develop Oct 29, 2020
@bharathkkb bharathkkb deleted the test-tf13-patch branch October 29, 2020 15:16
@bharathkkb bharathkkb mentioned this pull request Oct 29, 2020
bharathkkb added a commit that referenced this pull request Mar 30, 2021
bharathkkb added a commit that referenced this pull request Mar 30, 2021
bharathkkb added a commit that referenced this pull request Mar 30, 2021
bharathkkb added a commit that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for TF 0.13.x
3 participants