Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship binaries of NvStrapsReBar #17

Open
mezj opened this issue Feb 12, 2024 · 16 comments
Open

Ship binaries of NvStrapsReBar #17

mezj opened this issue Feb 12, 2024 · 16 comments

Comments

@mezj
Copy link

mezj commented Feb 12, 2024

Hi @terminatorul !
While looking through guide for NvStrapsReBar I did not notice restriction that it should be built on exactly the same machine where it is going to be added. Does it mean that there is no dependency on what computer is used for building?

If so, could you please ship prebuilt .ffs and .exe files of NvStrapsReBar, same as ReBarUEFI project did?
Thanks

@Black6spdZ
Copy link

No, it can be built on any machine.. and it takes information SPECIFIC to each setup prior to compiling the files tailored to the specific PC. Given enough time it may be streamlined to be easier

@mezj
Copy link
Author

mezj commented Feb 12, 2024

Just curious, what information is specific to each build? In "Building (Windows only)" guide I did not noticed any GPU or mo-bo specific information

@terminatorul
Copy link
Owner

terminatorul commented Feb 12, 2024

The latest version does not use hard-coded information about the current machine (can be built anywhere).

I still have some issues to sort out before making a binary release:

  • one user reported that clearing CMOS did not recover their machine, they had to move the GPU to a different slot (replacing the GPU in the same slot would also work, if you have an extra one). I have had a similar issue on my motherboard before, but I didn't have time to do a proper test
  • some users report resume from sleep gives a BSOD in Windows

so I am not ready to release binaries with above issues... and I do not have a lot of time for the extra development and debugging.... :(

@mezj
Copy link
Author

mezj commented Feb 12, 2024

@terminatorul

Thank you for answer. I understand that shipping "risky" binaries might raise number of complaints.

Still, adding paragraph to guide with proper disclaimer and link to binaries (maybe not Release section, but some web hosting site) might help people with BIOS programmers to save a lot of time to test NvStrapsReBar out :)

@xCuri0
Copy link

xCuri0 commented Feb 13, 2024

@terminatorul you can enable CI builds for those wanting experimental builds

I set up the configuration for it before in ReBarUEFI I guess you will have to change a few names in it but should be easy to setup

@Black6spdZ
Copy link

The latest version does not use hard-coded information about the current machine (can be built anywhere).

I still have some issues to sort out before making a binary release:

  • one user reported that clearing CMOS did not recover their machine, they had to move the GPU to a different slot (replacing the GPU in the same slot would also work, if you have an extra one). I have had a similar issue on my motherboard before, but I didn't have time to do a proper test
  • some users report resume from sleep gives a BSOD in Windows

so I am not ready to release binaries with above issues... and I do not have a lot of time for the extra development and debugging.... :(

so you are saying all the hardcoded stuff can be set with the NvStrapsReBar executable now??

@terminatorul
Copy link
Owner

terminatorul commented Feb 13, 2024

I got to check the Clear CMOS button an pin headers on my test motherboard (read: my safe motherboard, the one with Q-Flash Plus recovery feature, really saved me when I needed it).

And the result is I can not recover my board ... if I forget to disconnect computer from wall power, before clearing CMOS !

Maybe a rookie mistake, but I can't say I understand why can't the small button just work either way ... I guess the manufacturer tried to make sure the CMOS is under power whenever possible, and keep the circuitry around the button simple. Still unfriendly 'though...

I still want to implement a failsafe feature, so people don't have to open the case, or have to pull out the GPU to access the baterry, and clear CMOS... But it's not a priority now

@terminatorul
Copy link
Owner

terminatorul commented Feb 13, 2024

Now my board broke again ... for no reason. Clear CMOS button + pin header not recovering the board. It all started with unexplained WinAPI errors trying to write the EFI variable (the message only says "due to an I/O error" and the screen flickered...)

However this looks like a separate issue

@terminatorul
Copy link
Owner

@xCuri0
Copy link

xCuri0 commented Feb 19, 2024

Readme still looks like you have to manually build it, might want to change it a bit.

For ReBarUEFI I put build instructions in the wiki here can put in BUILDING.md I guess

@terminatorul
Copy link
Owner

I moved to wiki right away, maybe you just need a refresh

@unoMato
Copy link

unoMato commented Feb 20, 2024

Windows defender detecs Trojan:Win32/Wacatac.B!ml in NvStrapsReBar.exe

@terminatorul
Copy link
Owner

terminatorul commented Feb 20, 2024

@unoMato

I ran a quick scan of my computer using Microsoft Safety Scan, including NvStrapsReBar.exe file, it says it's ok ....
image

So I don't know what to say, Could you please also download Microsoft Safety Scan an runt the quick scan on your computer ?

I will run a full scan later. I also noticed 3 out of 72 scanners on VirusTotal say they detect something.

I recommend building from source. All source code in the executable has been written or re-written by me and there is nothing malicious in it. This project is fully open-source (MIT license)

@terminatorul
Copy link
Owner

I suppose automating the build with github actions would help deal with such problems as well, but the documentation and tutorials could fill a book, and I just can't deal with that now...

@unoMato
Copy link

unoMato commented Feb 23, 2024

@terminatorul

Sorry to keep you waiting, I wasn't at home for couple of days.

It most likely was false positive and maybe MS fixed it in later database update. When I started to download NvStrapsReBar.exe Defender said thread detected and removed it instantly. Now after couple of days I can download that file without issue and no threats are detected.

@terminatorul
Copy link
Owner

Thank you, I was worried for this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants