Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set enable_fast_runtime_mode to True by default #8364

Closed
8 tasks done
arakhmati opened this issue May 10, 2024 · 1 comment
Closed
8 tasks done

Set enable_fast_runtime_mode to True by default #8364

arakhmati opened this issue May 10, 2024 · 1 comment
Assignees
@arakhmati @ayerofieiev-tt

Comments

@arakhmati
Copy link
Contributor

arakhmati commented May 10, 2024 •
edited by ayerofieiev-tt

Currently, enable_fast_runtime_mode is set to False in ttnn but we want the users to run at the full speed by default

Before it can be set to True, the following needs to be done:

  • allow_to_fallback_to_golden_function_on_failure flag should be deleted
    • ttnn.reshape
    • ttnn.repeat
    • ttnn.repeat_interleave
    • ttnn.split
    • ttnn.pad
    • ttnn.Tensor.__getitem__
  • Some unit tests need to be set to enable_fast_runtime_mode=False to test features like validation, logging, etc
@ayerofieiev-tt
Copy link
Contributor

in progress now

ayerofieiev-tt added a commit that referenced this issue May 13, 2024
@ayerofieiev-tt
#8364: removed flag allow_to_fallback_to_golden_function_on_failure. …
2e58325 
…test run
ayerofieiev-tt added a commit that referenced this issue May 14, 2024
@ayerofieiev-tt
#8364: skip concat tests which fallback to torch
bf163e2
ayerofieiev-tt added a commit that referenced this issue May 14, 2024
@ayerofieiev-tt
#8364: remove senseless checks in ttnn.repeat_interleave
cec33e1
ayerofieiev-tt added a commit that referenced this issue May 14, 2024
@ayerofieiev-tt
#8364: skip repeat_interleaved tests as 2D tensors are not supported
ea2dda5
ayerofieiev-tt added a commit that referenced this issue May 14, 2024
@ayerofieiev-tt
#8364: skip ttnn.split tests as the operation is not implemented
5dc7cde
ayerofieiev-tt added a commit that referenced this issue May 14, 2024
@ayerofieiev-tt
#8364: skip tests in getitem
f4e1c13
ayerofieiev-tt added a commit that referenced this issue May 15, 2024
@ayerofieiev-tt
#8364: Revert "skip concat tests which fallback to torch"
47634f3 
This reverts commit bf163e2.
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: removed flag allow_to_fallback_to_golden_function_on_failure. …
ce23b6e 
…test run
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: skip concat tests which fallback to torch
91171cb
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: remove senseless checks in ttnn.repeat_interleave
a4a92a0
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: skip repeat_interleaved tests as 2D tensors are not supported
a9201c1
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: skip ttnn.split tests as the operation is not implemented
89ef111
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: skip tests in getitem
e24e90c
ayerofieiev-tt added a commit that referenced this issue May 18, 2024
@ayerofieiev-tt
#8364: Revert "skip concat tests which fallback to torch"
4e76616 
This reverts commit bf163e2.
ayerofieiev-tt added a commit that referenced this issue May 20, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
941fef8 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 21, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
c32f956 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 21, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
075f165 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 21, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
d635adb 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 21, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
791635d 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat
20fb5bb
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
4f47fb4 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
ff5998f 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
e34f478 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
49e6635 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
5d256fa 
…e usage
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 22, 2024
Merged
7 tasks
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for reshape, add ttnn.fallback.reshape, updat…
f2a043a 
…e usage
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat
653653d
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat
097dea4
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.repeat
dc3feb2
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat_interleave
09f61e8
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.repeat
9c0ecf3
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat_interleave
3dec3d5
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable fallback for ttnn.repeat_interleave
6a1209e
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: disable implicit fallback for ttnn.split
44e4238
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.split
15c675e
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 22, 2024
Merged
6 tasks
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.split
2a91be1
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.split
166a621
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.pad
4fe94d3
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 22, 2024
Merged
6 tasks
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.split
9a4c723
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.split
7514b14
ayerofieiev-tt added a commit that referenced this issue May 22, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.pad
5bd0bac
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for ttnn.pad
9e5a8b6
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for Tensor._getitem_
98de183
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 23, 2024
Merged
6 tasks
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for Tensor._getitem_
50afbdc
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Disable implicit fallback for Tensor._getitem_
deee3f7
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Remote allow_to_fallback_to_golden_function_on_failure flag fr…
74d22c7 
…om ttnn.Operation
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 23, 2024
Merged
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Remote allow_to_fallback_to_golden_function_on_failure flag fr…
18edb6a 
…om ttnn.Operation
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Remote allow_to_fallback_to_golden_function_on_failure flag fr…
dafc6de 
…om ttnn.Operation
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Split tests requiring fast runtime mode off
df0d179
ayerofieiev-tt added a commit that referenced this issue May 23, 2024
@ayerofieiev-tt
#8364: Split tests requiring fast runtime mode off
8090144
@ayerofieiev-tt ayerofieiev-tt mentioned this issue May 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arakhmati arakhmati

@ayerofieiev-tt ayerofieiev-tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arakhmati @ayerofieiev-tt