Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorized Matrices vs Factorized Tensors #28

Open
ashim95 opened this issue Sep 21, 2022 · 1 comment
Open

Tensorized Matrices vs Factorized Tensors #28

ashim95 opened this issue Sep 21, 2022 · 1 comment

Comments

@ashim95
Copy link

ashim95 commented Sep 21, 2022

Hi,

Thanks for creating and maintaining this library. I had a couple of basic questions, would be great if you could answer:

  1. What is the difference between the files in tltorch/factorized_tensors/factorized_tensors.py and tltorch/factorized_tensors/tensorized_matrices.py? A lot of the code is replicated across these files.

  2. Is BlockTT the same as Tensor-train?

  3. I know its trivial to implement, but does the library similarly have a module for low-rank matrix factorization?

Thanks,

@JeanKossaifi
Copy link
Member

Hi @ashim95 -- factorized tensors are just that: higher-order tensors in factorized form. Tensorized matrices are matrices that are tensorized. That tensorized form is expressed in factorized form. You can use it as a drop in replacement for matrices.

Block-TT is not the same as Tensor-Train (MPS), it would be the equivalent of TTM (that you may also know as MPO).

We don't yet have a low-rank matrix factorization module but you can get this by using a tensorized matrix with CP and a tensorized shape being the same as the original shape. However, I guess you mean taking a tensor, reshaping it to a matrix and decomposing that: it would be great to have this and would be awesome if you wanted to open a PR for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants