FutureWarning: Deprecated numpy API calls in tf.python.framework.dtypes #30427

habernal · 2019-07-05T07:18:31Z

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): not really
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS Mojave 10.14.5 (18F132)
TensorFlow installed from (source or binary): tensorflow==2.0.0b1 from https://pypi.org/
TensorFlow version (use command below): v2.0.0-beta0-16-g1d91213fe7 2.0.0-beta1
Python version: Python 3.6.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior

A plenty of FutureWarning errors:

/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint16 = np.dtype([("qint16", np.int16, 1)])
/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint32 = np.dtype([("qint32", np.int32, 1)])
/xxx/venv/lib/python3.6/site-packages/tensorflow-2.0.0b1-py3.6-macosx-10.14-x86_64.egg/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  np_resource = np.dtype([("resource", np.ubyte, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint16 = np.dtype([("qint16", np.int16, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint32 = np.dtype([("qint32", np.int32, 1)])
/xxx/venv/lib/python3.6/site-packages/tb_nightly-1.14.0a20190603-py3.6.egg/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  np_resource = np.dtype([("resource", np.ubyte, 1)])

Describe the expected behavior

No warnings.

Code to reproduce the issue

import tensorflow.python.framework.dtypes

print("Hello world")

The text was updated successfully, but these errors were encountered:

ravikyram · 2019-07-08T15:44:07Z

@habernal We have executed your code in Google colab and in Jupyter notebook with TF version
2.0 beta 1 and numpy version 1.16.4.We did not get any warnings.Please upgrade your numpy version and check whether the warnings still persists.Thanks!

habernal · 2019-07-09T06:16:04Z

Thanks, @ravikyram - I've double-checked the installed libraries and found the culprit.

TF 2.0.b1 comes with numpy dependency 1.16.4 and it shows no warning. So it is correct you couldn't reproduce the bug, neither could I.

However, it turned out that I had numpy 1.17.0rc1 installed in the project (no idea from which library it was linked as I certainly didn't install it by hand).

Numpy 1.17.0rc1 is responsible for complaining about these FutureWarnings. Perhaps not urgent to fix for now but once there is an upgrade to np 17, this will show up again, I guess.

habernal · 2019-07-09T07:01:12Z

In fact, the numpy dependency is treated differently given the tool you install TF (pip versus setuptools). Both tested in a clean virtual environment with only these libraries installed at the beginning:

pip==19.1.1 setuptools==41.0.1 wheel==0.33.4

Installing TF using pip:

$ pip install tensorflow==2.0.0b1 --no-cache-dir
...
Collecting numpy<2.0,>=1.14.5 (from tensorflow==2.0.0b1)
  Downloading https://files.pythonhosted.org/packages/...cc/numpy-1.16.4-cp36-cp....whl (13.9MB)
...

Installing TF as dependendy in setup.py containing only:

from setuptools import setup
setup(
    name='tf30427',
    version='0.0.1',
    install_requires=['tensorflow==2.0.0b1'],
)

and then installing as

$ python setup.py install
...
Searching for numpy<2.0,>=1.14.5
Reading https://pypi.org/simple/numpy/
Downloading https://files.pythonhosted.org/packages/e...17/numpy-1.17.0rc1-cp36-cp36...25e0
Best match: numpy 1.17.0rc1
Processing numpy-1.17.0rc1-cp36-cp36m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Installing numpy-1.17.0rc1-cp36-cp36m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl to /xxx/venv/lib/python3.6/site-packages
Adding numpy 1.17.0rc1 to easy-install.pth file
...

They understand the requirement numpy<2.0,>=1.14.5 differently: pip installs 1.16.4 while setuptools 1.17.0rc1.

Proposed fix:

Change the dependency to numpy<1.17,>=1.14.5 to stick with the 1.16 version regardless of the installation procedure.

habernal · 2019-07-09T08:05:57Z

And here's the core of the problem: pypa/setuptools#855

as discovered by others, too: https://stackoverflow.com/q/54796975

ravikyram · 2019-07-10T06:45:56Z

@habernal let me know if we can close this issue since we found the solution. Thanks!

yongtang · 2019-07-10T13:25:44Z

@habernal I think tensorflow could be updated to make it compatible with numpy 1.17+. Created a PR #30559 for the fix.

Akeaakar · 2019-07-27T13:54:32Z

Hello i am having the same error. Can u plese tell me what to do with instruction to solve this problem.Thanks

yongtang · 2019-07-27T15:00:09Z

@Akeaakar The issue has been fixed and merged into the master branch. In the next release of TF the issue should be gone.

ssomers · 2019-07-28T15:04:36Z

@Akeaakar And for the time being, pip install "numpy<1.17" to revert to numpy version 1.16.4

Zhiwei-Zhai · 2019-07-30T13:17:53Z

With Ubuntu19.04, the combination of tensorflow-gpu 1.14.0 (or tensorflow-gpu 1.12.2) with numpy 1.17.0 has the same warnings as well. When change numpy version to 1.16.3, the warnings are gone.

This commit integrates upstream changes into TensorBoard’s `tensorflow_stub` to resolve a deprecation warning in recent release candidates for NumPy. Upstream bug: <tensorflow/tensorflow#30427> Upstream fix: <tensorflow/tensorflow#30559>

njanirudh · 2019-08-20T08:52:15Z

Or you can supress the warnings using the below code.

import warnings
import tensorflow as tf

warnings.filterwarnings('ignore')

htuhxf · 2019-08-30T10:09:54Z

Or you can supress the warnings using the below code.
import warnings
import tensorflow as tf

warnings.filterwarnings('ignore')

seems this doesn't work for me. (numpy1.17.0 python3.7.3)

Gra-tak · 2019-09-04T13:05:24Z

Or you can supress the warnings using the below code.
import warnings
import tensorflow as tf

warnings.filterwarnings('ignore')
seems this doesn't work for me. (numpy1.17.0 python3.7.3)

import warnings
warnings.filterwarnings('ignore',category=FutureWarning)
import tensorflow as tf

Needs to be before the import, since that is where the warnings are coming from. Also added a restriction to only effect that warning category instead of silencing all warnings.

Michael-VT · 2019-09-08T15:02:37Z

import warnings
warnings.filterwarnings('ignore',category=FutureWarning)
import tensorflow as tf
It works for me even under a virtual environment

csarami · 2019-09-13T22:47:11Z

I have numpy in ./venv/lib/python3.7/site-packages (1.17.2). In both Jupyter and VS Code, I get the idea. I really dislike the idea of ignoring the warning. Any fixes would be greatly appreciated.

arianaa30 · 2019-09-17T16:59:46Z

pip install "numpy<1.17"

After doing that, system installed numpy-1.16.5. But now import tensorflow says:
ImportError: Something is wrong with the numpy installation.

jagadeeshjr5 · 2019-09-20T07:43:53Z

numpy: pip install --upgrade numpy
keras: conda install -c conda-forge keras

Upgrade your numpy and install keras by using the above command in Anaconda prompt.

Namburger · 2019-09-24T17:18:03Z

Hi, for reference, I got this fixed with these 2 version:

>>> import tensorflow as tf
>>> print(tf.__version__)
2.0.0-rc1
>>> import numpy as np
>>> print(np.__version__)
1.17.2
>>> exit()

09/24/19, hope this helps

askerlee · 2019-09-29T10:00:12Z

Thanks @Namburger . The warnings are gone on 2.0.0-rc1.

UndeadKernel · 2019-10-02T14:23:17Z

With the latest release of tensorflow (i.e., 2.0.0) and numpy 1.17.2, the warning is back.

mihaimaruseac · 2019-10-13T21:21:58Z

Can you provide a reproducer, @UndeadKernel ? I cannot reproduce:

>>> import tensorflow as tf
>>> tf.__version__
'2.0.0'
>>> import numpy as np
>>> np.__version__
'1.17.2'
>>> import tensorflow.python.framework.dtypes
>>>

Also tried from a file:

import tensorflow as tf
import numpy as np

print("TF", tf.__version__)
print("NP", np.__version__)

import tensorflow.python.framework.dtypes

but no warnings:

(gh_numpty) mihaimaruseac@ankh:/tmp/gh_numpty$ python test.py 
TF 2.0.0
NP 1.17.2

UndeadKernel · 2019-10-14T10:22:51Z

@mihaimaruseac, I can reproduce the problem with both examples of yours. That is, I see the following output:

2019-10-14 12:20:56.438892: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudart.so.10.1
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint16 = np.dtype([("qint16", np.int16, 1)])
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint32 = np.dtype([("qint32", np.int32, 1)])
/usr/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  np_resource = np.dtype([("resource", np.ubyte, 1)])
TF 2.0.0
NP 1.17.2

I'm using arch. Arch, if I recall correctly, adapts Tensorflow to work with Python 3.7.4. Or is this version of Python already supported by Tensorflow?

rharish101 · 2019-10-14T10:36:43Z

@UndeadKernel I'm running Arch too, but I'm not getting any warnings as of now (they were present earlier). My packages are:

python-tensorflow-opt-cuda: 2.0.0-2
python-numpy-openblas: 1.17.2-1

UndeadKernel · 2019-10-14T14:07:12Z

This is indeed quite strange @rharish101, I have the same exact versions. I tried using python-numpy from the official repo and python-numpy-openblas` from the AUR and I see the same FutureWarning messages.

rharish101 · 2019-10-14T14:32:34Z

@UndeadKernel Could you try reinstalling the TensorFlow package? It might have changed in the latest patch (2.0.0-2 as opposed to 2.0.0-1). I remember that I, too, saw those warnings in the last few days, but as of today, they are gone, with the only difference that I updated TensorFlow 9 days ago.

UndeadKernel · 2019-10-14T14:45:46Z

@rharish101, thank for the suggestion.
I noticed that tensorboard was not the same version as tensorflow. After reinstalling tensorboard (notice that this is "tensorBoard" and not "TensorFlow"), the warning went away.

mihaimaruseac · 2019-10-14T15:39:40Z

There is an official release of 2.0, you should not need to use the patched versions.

UndeadKernel · 2019-10-14T20:35:22Z

To which patches are you referring @mihaimaruseac?

mihaimaruseac · 2019-10-14T20:55:11Z

2.0.0-1 and 2.0.0-2 mentioned in above comments

pip install tensorflow==2.0.0 should work (might need to upgrade pip to the latest version if you're on an old one, due to the change to be manylinux2010 compliant)

See tensorflow/tensorflow#30427

As a test, only suppressing single import of Keras (and hence TF backend) that occurs when importing conf directly. Reference: tensorflow/tensorflow#30427

Benjamin0000Rodriguez · 2019-11-07T06:12:46Z

try

pip3 [pip] install tf-nightly

the nightly build of tensorflow seems to have that problem sorted out, best of luck

FoxerLee · 2019-12-02T15:24:15Z

for tensorflow==2.0.0 and numpy==1.17.4

I don't get the error/warning.

You can try as:

>>> import tensorflow as tf
>>> tf.__version__
'2.0.0'
>>> import numpy as np
>>> np.__version__
'1.17.4'
>>> import tensorflow.python.framework.dtypes
>>>

jean-noelp · 2020-02-04T15:53:25Z

@Akeaakar And for the time being, pip install "numpy<1.17" to revert to numpy version 1.16.4

And also for anaconda:
conda install "numpy<1.17"

louiselmps · 2020-04-30T12:14:27Z

And for the time being, pip install "numpy<1.17" to revert to numpy version 1.16.4

After how many hours this was the one that solved my problem. I installed the TF that had the numpy version installed (18.0) and when i reverted it to 1.16.4 it works! thanks

ravikyram self-assigned this Jul 8, 2019

ravikyram added 2.0.0-beta0 type:support Support issues labels Jul 8, 2019

ravikyram added comp:apis Highlevel API related issues stat:awaiting response Status - Awaiting response from author labels Jul 8, 2019

tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Jul 9, 2019

ravikyram added the stat:awaiting response Status - Awaiting response from author label Jul 10, 2019

habernal mentioned this issue Jul 10, 2019

Disallowing numpy 1.17 onwards as dependency #30553

Closed

yongtang mentioned this issue Jul 10, 2019

Fix numpy warning with numpy 1.17.0+ #30559

Merged

tensorflow-copybara closed this as completed in #30559 Jul 10, 2019

habernal mentioned this issue Jul 31, 2019

Fix warning with numpy 17.x+ tensorflow/tensorboard#2482

Merged

ravikyram mentioned this issue Aug 7, 2019

Tons of warnings just by importing tf (2.0.0-beta1) #31364

Closed

xgirouxb mentioned this issue Sep 10, 2019

update Dockerfile with new jupyter/scipy-notebook and packages gee-community/ee-jupyter-contrib#41

Merged

MaximeKjaer added a commit to MaximeKjaer/tf-dotty that referenced this issue Oct 29, 2019

Fix TensorFlow and numpy warnings

b632f1e

See tensorflow/tensorflow#30427

marcomeola mentioned this issue Nov 8, 2019

numpy 1.17 gives error/warning biocore/mmvec#102

Closed

Notgnoshi mentioned this issue Mar 22, 2020

Fix tensorflow/numpy version conflict Notgnoshi/research#56

Closed

fridex mentioned this issue Apr 7, 2020

Thoth Thamos CLI AICoE/learn-katacoda#29

Merged

lvenugopalan added the TF 2.0 Issues relating to TensorFlow 2.0 label Apr 29, 2020

CAM-Gerlach mentioned this issue Jun 29, 2020

Error message on missing dependencies : Jedi and Pyls spyder-ide/spyder#13008

Closed

Harmon758 mentioned this issue Jan 8, 2021

FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'. _np_qint32 = np.dtype([("qint32", np.int32, 1)]) #40500

Closed

jeylau mentioned this issue Apr 13, 2021

testscript.py issue --- ImportError: No module named deeplabcut DeepLabCut/DeepLabCut#1188

Closed

Saduf2019 mentioned this issue Apr 29, 2021

Tensorflow 2.3 or up Installation on Mac OS Big Sur 11.3 #48808

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FutureWarning: Deprecated numpy API calls in tf.python.framework.dtypes #30427

FutureWarning: Deprecated numpy API calls in tf.python.framework.dtypes #30427

habernal commented Jul 5, 2019

ravikyram commented Jul 8, 2019

habernal commented Jul 9, 2019

habernal commented Jul 9, 2019

habernal commented Jul 9, 2019

ravikyram commented Jul 10, 2019

yongtang commented Jul 10, 2019

Akeaakar commented Jul 27, 2019

yongtang commented Jul 27, 2019

ssomers commented Jul 28, 2019

Zhiwei-Zhai commented Jul 30, 2019

njanirudh commented Aug 20, 2019 •

edited

htuhxf commented Aug 30, 2019

Gra-tak commented Sep 4, 2019 •

edited

Michael-VT commented Sep 8, 2019

csarami commented Sep 13, 2019

arianaa30 commented Sep 17, 2019 •

edited

jagadeeshjr5 commented Sep 20, 2019 •

edited

Namburger commented Sep 24, 2019

askerlee commented Sep 29, 2019

UndeadKernel commented Oct 2, 2019

mihaimaruseac commented Oct 13, 2019

UndeadKernel commented Oct 14, 2019

rharish101 commented Oct 14, 2019 •

edited

UndeadKernel commented Oct 14, 2019

rharish101 commented Oct 14, 2019

UndeadKernel commented Oct 14, 2019

mihaimaruseac commented Oct 14, 2019

UndeadKernel commented Oct 14, 2019

mihaimaruseac commented Oct 14, 2019

Benjamin0000Rodriguez commented Nov 7, 2019

FoxerLee commented Dec 2, 2019

jean-noelp commented Feb 4, 2020 •

edited

louiselmps commented Apr 30, 2020

FutureWarning: Deprecated numpy API calls in tf.python.framework.dtypes #30427

FutureWarning: Deprecated numpy API calls in tf.python.framework.dtypes #30427

Comments

habernal commented Jul 5, 2019

ravikyram commented Jul 8, 2019

habernal commented Jul 9, 2019

habernal commented Jul 9, 2019

habernal commented Jul 9, 2019

ravikyram commented Jul 10, 2019

yongtang commented Jul 10, 2019

Akeaakar commented Jul 27, 2019

yongtang commented Jul 27, 2019

ssomers commented Jul 28, 2019

Zhiwei-Zhai commented Jul 30, 2019

njanirudh commented Aug 20, 2019 • edited

htuhxf commented Aug 30, 2019

Gra-tak commented Sep 4, 2019 • edited

Michael-VT commented Sep 8, 2019

csarami commented Sep 13, 2019

arianaa30 commented Sep 17, 2019 • edited

jagadeeshjr5 commented Sep 20, 2019 • edited

Namburger commented Sep 24, 2019

askerlee commented Sep 29, 2019

UndeadKernel commented Oct 2, 2019

mihaimaruseac commented Oct 13, 2019

UndeadKernel commented Oct 14, 2019

rharish101 commented Oct 14, 2019 • edited

UndeadKernel commented Oct 14, 2019

rharish101 commented Oct 14, 2019

UndeadKernel commented Oct 14, 2019

mihaimaruseac commented Oct 14, 2019

UndeadKernel commented Oct 14, 2019

mihaimaruseac commented Oct 14, 2019

Benjamin0000Rodriguez commented Nov 7, 2019

FoxerLee commented Dec 2, 2019

jean-noelp commented Feb 4, 2020 • edited

louiselmps commented Apr 30, 2020

njanirudh commented Aug 20, 2019 •

edited

Gra-tak commented Sep 4, 2019 •

edited

arianaa30 commented Sep 17, 2019 •

edited

jagadeeshjr5 commented Sep 20, 2019 •

edited

rharish101 commented Oct 14, 2019 •

edited

jean-noelp commented Feb 4, 2020 •

edited