Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower() to string operations #25857

Closed
arwentwinkle opened this issue Feb 19, 2019 · 1 comment · Fixed by #25859
Closed

Add lower() to string operations #25857

arwentwinkle opened this issue Feb 19, 2019 · 1 comment · Fixed by #25859
Assignees
Labels
comp:ops OPs related issues type:feature Feature requests

Comments

@arwentwinkle
Copy link

System information

  • TensorFlow version (you are using): 1.10 and 1.12
  • Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Add the string lower() function to the tf.string class.
Current state has no way to lower case input strings. This requires it to be done at dataset build time which reduces dataset flexibility

Will this change the current api? How?
Would add extra functionality

Who will benefit with this feature?
All users doing natural language processing

Any Other info.

@yongtang
Copy link
Member

Added a PR #25859 with strings.lower() and strings.upper().

@ymodak ymodak self-assigned this Feb 19, 2019
@ymodak ymodak added type:feature Feature requests comp:ops OPs related issues labels Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ops OPs related issues type:feature Feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants