{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":91379993,"defaultBranch":"master","name":"tensorboard","ownerLogin":"tensorflow","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-15T20:08:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/15658638?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714381795.0","currentOid":""},"activityList":{"items":[{"before":"aa5427294c99d95b6e0bdf47fd79e4aa23db79bc","after":"d5a27132d450b84f805142e5e35845ff6b67825c","ref":"refs/heads/master","pushedAt":"2024-05-13T02:15:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global pins] enable globalpins by default (#6850)\n\n## Motivation for features / changes\r\nlaunch global pins feature by enabling the feature by default \r\n## Technical description of changes\r\n\r\n## Screenshots of UI changes (or N/A)\r\n### Light mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/c5163d74-a5ef-4ba0-969b-4a87111d55c7)\r\n\r\n### Dark mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/d568f957-9d55-4b93-bb65-7bca50e6c39f)\r\n#### pop up\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/9ce2939c-390f-4d2a-b464-a92ab7c4a52b)\r\n\r\n### Corp theme\r\n\"image\"\r\nsrc=\"https://github.com/tensorflow/tensorboard/assets/24772412/231a68f1-4ab0-4c6e-ab82-15ec1f17181c\"\r\n\r\n\r\nhttps://screenshot.googleplex.com/7WaVHXBFfAfHYUk\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n* Needs to update scuba test images after this PR is merged\r\n\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global pins] enable globalpins by default (#6850)"}},{"before":"29850f60307925a15c369fecdb694a05baf77390","after":"aa5427294c99d95b6e0bdf47fd79e4aa23db79bc","ref":"refs/heads/master","pushedAt":"2024-05-08T13:45:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AnuarTB","name":"Anuar Talipov","path":"/AnuarTB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5575949?s=80&v=4"},"commit":{"message":"Group colours by regex of the experiment name. (#6846)\n\n## Motivation for features / changes\r\n\r\nUsers want to color runs by the regex string of the corresponding to\r\nruns experiment names.\r\n\r\n## Technical description of changes\r\n\r\n- Added new GroupBy type, REGEX_BY_EXP.\r\n- Added a dropdown in dialog window, so users could select between regex\r\nfor run name or experiment name.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\nN/A since internal change. \r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n\r\n- Run tensorboard.corp server.\r\n- Click on color grouping icon and select `Regex`.\r\n- Select `Experiment Name` in dropdown.\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"Group colours by regex of the experiment name. (#6846)"}},{"before":"d4c5c825a5677bf1d22d1d9290bb439f0ce7e861","after":"29850f60307925a15c369fecdb694a05baf77390","ref":"refs/heads/master","pushedAt":"2024-05-08T11:44:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] Saves all currently pinned cards if the user has enabled global pins. (#6848)\n\n## Motivation for features / changes\r\n\r\nFeature request during the teamfood: `Clicking disable pins -> pinning a\r\ncard -> clicking enable pins` doesn't save the currently pinned card. It\r\nseems reasonable to save all currently pinned cards when the setting is\r\nactivated.\r\n\r\nThis PR saves all currently pinned cards when user clicks enable global\r\npins.\r\n\r\n## Technical description of changes\r\n\r\n* 97c6324389e1a9a5f51b89e5e33b0665ead533a4 Added `saveScalarPins` to the\r\ndata source\r\n\r\n* c6be93b Modified `addOrRemovePinsOnToggle` logic to include adding\r\npins logic\r\n* Previously, if a user disabled the global pin feature, all pins would\r\nbe removed.\r\n* This PR added logic that will cause all currently pinned cards to be\r\nsaved to local storage when the user activates the feature.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nN/A\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nUnit test passes\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A","shortMessageHtmlLink":"[Global Pins] Saves all currently pinned cards if the user has enable…"}},{"before":"af346056e1c158b6ed6a38b136af648b2e12a986","after":"d4c5c825a5677bf1d22d1d9290bb439f0ce7e861","ref":"refs/heads/master","pushedAt":"2024-05-02T13:41:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] [Quick Fix] Apply theme color to the check box (#6845)\n\n## Motivation for features / changes\r\nTheme color was not applied to the checkbox. \r\n## Technical description of changes\r\nApply `color=\"primary\"` to the `saving_pins_checkbox_component`\r\n\r\n## Screenshots of UI changes (or N/A)\r\nAS-IS\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/12ed994a-a3b4-4137-b7b8-7a22b4a9af37)\r\n\r\n\r\nTO-BE\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/2aa3fbd7-b46e-46fd-b365-debc72cf2883)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\ntested with ` tb_theme=corp` & TAP presubmit passes\r\n\r\n\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global Pins] [Quick Fix] Apply theme color to the check box (#6845)"}},{"before":"ad1da0c01f29cc96fe39677b6104110e9a55decd","after":"af346056e1c158b6ed6a38b136af648b2e12a986","ref":"refs/heads/master","pushedAt":"2024-04-30T06:26:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] Shows a confirmation dialog when disabling the global pin feature (#6843)\n\n## Motivation for features / changes\r\nRegarding #6831 , this PR adds confirmation dialog\" that appears when\r\nthe user clears the checkbox to make the user aware that local storage\r\nis disappearing.\r\n\r\n## Technical description of changes\r\n0e63b07 created a `saving pins dialog` component\r\n\r\n05e06f5 Created a `saving pins checkbox` component\r\n* The Save Pin checkbox prevents the default click and must be done\r\nafter confirmation in the modal. So I added\r\n`MAT_CHECKBOX_DEFAULT_OPTIONS`\r\n(https://v15.material.angular.io/comComponents/checkbox/overview#click-action-config)\r\nto prevent the default click event. However, if I add this directly to\r\nthe `settings view component`, all checkboxes will be disabled,\r\nincluding other unwanted ones. So, I created a separate checkbox for the\r\nSave Pin checkbox. Please let me know is there any other good way to do\r\nthis.\r\n\r\n6ba778e Make the dialog shows up when user clears the checkbox\r\n* Passes to `onEnableSavingPinsToggled` whether the checkbox is\r\nselected.\r\n* If the checkbox is selected and user clicks it, it means that the user\r\ndisables the global pin, so a dialog box is displayed.\r\n* If the checkbox is not checked but is clicked, it means the user is\r\ntrying to enable a global pin and no dialog box will be displayed.\r\n* `onEnableSavingPinsToggled` and `isSavingPinsEnabled` is passed to\r\n`saving-pins-checkbox` component.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/eb442565-4f39-45e7-b893-4866ee3fc1e4)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nunit test passes + TAP presubmit passes \r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global Pins] Shows a confirmation dialog when disabling the global p…"}},{"before":"0c8596b5ad3c487e3a4729cac3571b4b542792b5","after":null,"ref":"refs/heads/add_column_final","pushedAt":"2024-04-29T09:09:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":"e9d000985c93e46852ba610bb0afbaeab5d4c4d1","after":"ad1da0c01f29cc96fe39677b6104110e9a55decd","ref":"refs/heads/master","pushedAt":"2024-04-29T09:09:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Makes data table add column sticky (#6839)\n\n## Motivation for features / changes\r\nThe add column button in the runs table will be hidden when the table is\r\nwide, which will often be the case. This makes the \"add\" feature very\r\ndifficult to discover.\r\n\r\ncontext: b/332788091\r\n\r\n## Technical description of changes\r\n- Moves the add button column outside of and adjacent to the data table\r\n(previously it was a column of the table) and makes it sticky\r\n- Adds additional configuration options to data table to allow runs and\r\nscalar tables to have slightly different designs\r\n\r\n## Screenshots of UI changes (or N/A)\r\nNotice the add column is fixed to the right:\r\n\r\n![sticky](https://github.com/tensorflow/tensorboard/assets/736199/0f7aca5c-0903-438a-bafd-ddc033e262f7)\r\n\r\nScalar table add column is slightly narrower:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/e8c37505-4c3f-41bd-98f3-3b31f99e206e)\r\n\r\n## Alternate designs / implementations considered (or N/A)\r\n- Tried adding the add columns to the consumer components of the data\r\ntable (runs data table and scalar card data table) instead. But this led\r\nto too much code duplication in the components and templates.\r\n- Tried making the add column a regular table column, instead of adding\r\nit outside in a separate div. But making the column sticky requires\r\nstyling the table rows, which data table doesn't provide access to (rows\r\nare configured solely in the consumer components). Also, the chosen\r\nimplementation is arguably more consistent with the current design as\r\nthe add \"column\" doesn't actually function as a table column at all","shortMessageHtmlLink":"Makes data table add column sticky (#6839)"}},{"before":"24d62c4df7207ea767db23564d457c08344224f6","after":"0c8596b5ad3c487e3a4729cac3571b4b542792b5","ref":"refs/heads/add_column_final","pushedAt":"2024-04-29T06:31:58.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Merge branch 'master' into add_column_final","shortMessageHtmlLink":"Merge branch 'master' into add_column_final"}},{"before":"781e9800c0151c8ae30d1408af820bd5846257c5","after":null,"ref":"refs/heads/fix_scroll_final","pushedAt":"2024-04-29T06:25:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":"4023658707d54976622c3b3a32f5a4a215689da7","after":"e9d000985c93e46852ba610bb0afbaeab5d4c4d1","ref":"refs/heads/master","pushedAt":"2024-04-29T06:25:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"[Runs table] Moves expand button to layout container and fixes sidebar scroll (#6837)\n\n## Motivation for features / changes\r\n- Moving the expand button out of the runs table is required to make it\r\ncompatible with the upcoming sticky add column b/332788091\r\n- When the table is both vertically long and horizontally wide, it's\r\nvery difficult to scroll horizontally: users must scroll all the way to\r\nthe bottom of the table in order to access the horizontal scroll bar.\r\nb/332720882\r\n\r\n## Technical description of changes\r\n- Moves the \"expand button\" from inside the runs data table to the\r\nLayoutContainer (in the side bar).\r\n- Moves the \"overflow\" css property from the runs table to\r\nRunsSelectorComponent (the runs table wrapper)\r\n- Makes the runs table header sticky. This was already set, but wasn't\r\nbeing applied due to a missing \"position: relative\" parent.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nsticky header:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/f2569648-6395-4411-9302-f626b6bd5e9f)\r\n\r\nexpand table button:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/736199/35b2e624-f015-41dc-9114-0cab63b70eef)","shortMessageHtmlLink":"[Runs table] Moves expand button to layout container and fixes sideba…"}},{"before":"9f51a3008ad1506b5a9ec43d354408d5f75df2ed","after":"4023658707d54976622c3b3a32f5a4a215689da7","ref":"refs/heads/master","pushedAt":"2024-04-24T22:48:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global pins] Correct the incorrect name change and add test cases (#6840)\n\n## Motivation for features / changes\r\n\r\nThis PR fixes the renaming in #6831 and adds test cases to make the test\r\nrobust.\r\n\r\n## Technical description of changes\r\n\r\n* Tried to rename `disableSavingPins` to `removeSavedPinsOnDisable`, but\r\n#6831 accidentally changed `removeAllPins` to\r\n`removeSavedPinsOnDisable`.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\n* Added test cases + cl TAP presubmit passes\r\n## Alternate designs / implementations considered (or N/A)","shortMessageHtmlLink":"[Global pins] Correct the incorrect name change and add test cases (#…"}},{"before":"e11681dd158fe0e35bc7a25dea5d44d389dd69d5","after":"781e9800c0151c8ae30d1408af820bd5846257c5","ref":"refs/heads/fix_scroll_final","pushedAt":"2024-04-24T14:30:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Remove unused css variable","shortMessageHtmlLink":"Remove unused css variable"}},{"before":"b38870237b7f4a55a7f43a83178c03218cb4595c","after":"24d62c4df7207ea767db23564d457c08344224f6","ref":"refs/heads/add_column_final","pushedAt":"2024-04-24T14:26:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Addresses review comments","shortMessageHtmlLink":"Addresses review comments"}},{"before":"98f026029ba4e301140b72aa968578be5a036742","after":null,"ref":"refs/heads/memoize_column_fn","pushedAt":"2024-04-24T11:19:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":"aa315d32ce6586ced30018e47efd07ee37b6beb5","after":"9f51a3008ad1506b5a9ec43d354408d5f75df2ed","ref":"refs/heads/master","pushedAt":"2024-04-24T11:19:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Memoizes the functions for getting header both runs and scalar data tables (#6836)\n\n## Motivation for features / changes\r\nUsing functions in Angular templates leads to unnecessary recomputation,\r\ne.g. getHeaders() is called 60 times from data tables on init and add).\r\nMore seriously, they also interfere with other component usage like CDK\r\nOverlay: namely, when an Overlay is set to appear next to a header, the\r\nheader element is destroyed and recreated (because of the function in\r\nthe template) before the Overlay can position itself, and ends up always\r\nresetting its position to (0,0). Simply memoizing the function will\r\nprevent the recomputation ([Angular\r\nref](https://angular.io/guide/change-detection-slow-computations#optimizing-slow-computations)).\r\n\r\nProfiling the memoized change (using Chrome devtools profiler, which is\r\nadmittedly a bit inconsistent) seems to show a several 100ms improvement\r\nin scripting performance.\r\n\r\n## Technical description of changes\r\nReplaces the `getHeaders` functions used in scalar/runs data tables with\r\na new memoized `extendHeaders(headers)` function.\r\n\r\nNo change in UI behavior.\r\n\r\n## Screenshots of UI changes (or N/A)\r\nN/A","shortMessageHtmlLink":"Memoizes the functions for getting header both runs and scalar data t…"}},{"before":"f2e8bd82a533c175f6dc5be3da65344d719ae0f6","after":"aa315d32ce6586ced30018e47efd07ee37b6beb5","ref":"refs/heads/master","pushedAt":"2024-04-24T06:48:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Re-disables enableScalarColumnContextMenus flag (#6838)\n\n## Motivation for features / changes\r\nIn 3p, enabling standard (non-hparam column) hide is currently dangerous\r\nas there is currently no way to re-show them. Enabling for 3p will have\r\nto wait until we add an affordance other than the 1p-only column\r\ncustomizer.\r\n\r\nAffected users can clear localStorage for the page, or add the\r\n`enableScalarColumnCustomization=true` flag to enable the column\r\ncustomizer in the settings menu and re-add hidden columns.\r\n\r\n## Technical description of changes\r\nSets `enableScalarColumnContextMenus` default to `false`. (Reverts\r\n#6817)","shortMessageHtmlLink":"Re-disables enableScalarColumnContextMenus flag (#6838)"}},{"before":null,"after":"b38870237b7f4a55a7f43a83178c03218cb4595c","ref":"refs/heads/add_column_final","pushedAt":"2024-04-22T09:46:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Fixes test","shortMessageHtmlLink":"Fixes test"}},{"before":null,"after":"e11681dd158fe0e35bc7a25dea5d44d389dd69d5","ref":"refs/heads/fix_scroll_final","pushedAt":"2024-04-22T07:10:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Moves expand button to layout container and fixes sidebar scroll","shortMessageHtmlLink":"Moves expand button to layout container and fixes sidebar scroll"}},{"before":"24d55042f337276c3ec9039ac5600f9d7619e364","after":"98f026029ba4e301140b72aa968578be5a036742","ref":"refs/heads/memoize_column_fn","pushedAt":"2024-04-22T07:04:51.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Merge branch 'master' into memoize_column_fn","shortMessageHtmlLink":"Merge branch 'master' into memoize_column_fn"}},{"before":"874f348732b9de8c37db8a96705a1b0438fa4f4c","after":null,"ref":"refs/heads/fix_runs_table_scroll","pushedAt":"2024-04-22T07:02:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"}},{"before":null,"after":"874f348732b9de8c37db8a96705a1b0438fa4f4c","ref":"refs/heads/fix_runs_table_scroll","pushedAt":"2024-04-22T07:01:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Moves expand button to layout container and fixes sidebar scroll","shortMessageHtmlLink":"Moves expand button to layout container and fixes sidebar scroll"}},{"before":null,"after":"24d55042f337276c3ec9039ac5600f9d7619e364","ref":"refs/heads/memoize_column_fn","pushedAt":"2024-04-22T04:52:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hoonji","name":null,"path":"/hoonji","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/736199?s=80&v=4"},"commit":{"message":"Fixes test","shortMessageHtmlLink":"Fixes test"}},{"before":"9ff1585ce2cbcbc35b09d9488f19bf5a586f1aa6","after":"f2e8bd82a533c175f6dc5be3da65344d719ae0f6","ref":"refs/heads/master","pushedAt":"2024-04-19T21:31:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"arcra","name":"Adrian RC","path":"/arcra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1861094?s=80&v=4"},"commit":{"message":"Preserve white space in text plugin. (#6833)\n\nSome users require the spaces to be preserved in the text shown in the\r\ntext dashboard.\r\n\r\nAt the moment I can't think of a reason why not to enable this\r\nunconditionally. I imagine anybody interested in seeing text logged\r\nwould be interested in the value *verbatim*, including spaces.\r\n\r\nGooglers, see b/335770352","shortMessageHtmlLink":"Preserve white space in text plugin. (#6833)"}},{"before":"11351617439443764053b13ad564522078571257","after":"9ff1585ce2cbcbc35b09d9488f19bf5a586f1aa6","ref":"refs/heads/master","pushedAt":"2024-04-19T05:35:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global Pins] Added a disabling global pins feature (#6831)\n\n## Motivation for features / changes\r\nFollowing #6828,\r\n\r\nSince global pins are applied automatically, this PR allows users\r\ndisable the global pin feature.\r\n\r\n## Technical description of changes\r\n2cf2b11 Added `savingPinsEnabled` in the `MetricsSettings`\r\n* Also added a selector getting `settings.savingPinsEnabled` value from\r\nthe store.\r\n\r\ndec6a63 Introduced new action `metricsEnableSavingPinsToggled`\r\n* If `metricsEnableSavingPinsToggled` is dispatched, it toggles the\r\n`savingPinsEnabled` store value.\r\n\r\n6ea22fd Added a checkbox UI to the settings view component.\r\n* Also added a feature flag guard to the component. If check box is\r\nclicked, it dispatched `metricsEnableSavingPinsToggled` action.\r\n\r\n568febf Added a new effect `disableSavingPins`\r\n* When `metricsEnableSavingPinsToggled` action is called, this effect\r\nwill call `removeAllScalarPins` method if `savingPinsEnabled` value is\r\nfalse.\r\n \r\nbbf9050 Added saving pins feature in persistent settings to preserve\r\nuser preferences.\r\n\r\n3ff7cd2 Add buildMetricsSettingsOverrides util in the testing to use in\r\ntbcorp\r\n\r\n## Screenshots of UI changes (or N/A)\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/874dbc2b-f01f-4112-b34b-6b07330ea31f)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nUnit test passes + created a cl/625208577 to pass TAP Presubmit tests\r\n## Alternate designs / implementations considered (or N/A)\r\nN/A\r\n\r\n## Action Items in the next PR\r\nIn the next PR, I'll add a \"confirmation dialog\" that appears when the\r\nuser unchecks the checkbox to make the user aware that local storage is\r\ndisappearing.\r\n\r\n- [ ] Add the confirmation dialog","shortMessageHtmlLink":"[Global Pins] Added a disabling global pins feature (#6831)"}},{"before":"896c7785fef927279b0c78304d5d3ec6293d34a3","after":"11351617439443764053b13ad564522078571257","ref":"refs/heads/master","pushedAt":"2024-04-16T16:08:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bmd3k","name":"Brian Dubois","path":"/bmd3k","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17152369?s=80&v=4"},"commit":{"message":"Bump tar from 6.1.12 to 6.2.1 (#6827)\n\nBumps [tar](https://github.com/isaacs/node-tar) from 6.1.12 to 6.2.1.\r\n\r\nSigned-off-by: dependabot[bot] \r\nCo-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>","shortMessageHtmlLink":"Bump tar from 6.1.12 to 6.2.1 (#6827)"}},{"before":"5e4ec76d4637c34d5196e238031d79d69e6ff2d4","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/tar-6.2.1","pushedAt":"2024-04-16T16:08:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bmd3k","name":"Brian Dubois","path":"/bmd3k","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17152369?s=80&v=4"}},{"before":"6f1cbcb14511b8baa71f816fef24e9ca82691c93","after":"896c7785fef927279b0c78304d5d3ec6293d34a3","ref":"refs/heads/master","pushedAt":"2024-04-16T02:46:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"roseayeon","name":"Seayeon Lee","path":"/roseayeon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24772412?s=80&v=4"},"commit":{"message":"[Global pins] Add clear all pins button (#6828)\n\n## Motivation for features / changes\r\nFollowing #6821 As pin data is accumulated, unwanted pins can easily\r\ncrowd the dashboard. Therefore, this PR adds a button that allows users\r\nto conveniently clear all pins at once.\r\n\r\n## Technical description of changes\r\n* 57c6a47 Introduced new action called `metricsClearAllPinnedCards`\r\n* When `metricsClearAllPinnedCards` is dispatched, the reducer removed\r\nall pinned cards in the state.\r\n\r\n* a04c2d7 Added `clear all pins` button in the pinned view container.\r\n * The button will be shown if there's at least one pinned card.\r\n\r\n* f0c3a54 Implemented `removeAllScalarPins` method in the saved pins\r\ndata source.\r\n * This method removes stored pins from local storage.\r\n\r\n* e97b110 Added `removeAllPins` effect in the `metrics/effects/index.ts`\r\n* When `metricsClearAllPinnedCards` action is called, this effect will\r\ncall `removeAllScalarPins` method defined in the saved pin data source.\r\n\r\n* c0edd37 guarded UI feature (button) with feature flag and added\r\nrelated tests.\r\n\r\n## Screenshots of UI changes (or N/A)\r\n### Light mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/a0793e8b-7fea-45f0-b2d8-4e742ca40918)\r\n\r\n\r\n### Dark mode\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/24772412/581468a1-1a9c-4ab4-b70a-13c5a5b168f6)\r\n\r\n## Detailed steps to verify changes work correctly (as executed by you)\r\nUnit test pass & cl TAP presubmit pass\r\n## Alternate designs / implementations considered (or N/A)\r\nI also considered a feature to select a pinned card and remove the\r\nselected pinned card, but I thought that this would be the same as\r\npressing the 'unpin' button individually from the user's perspective. So\r\nI implemented a 'clear all pins' button that removes all pinned cards.\r\nAny feedback is appreciated!","shortMessageHtmlLink":"[Global pins] Add clear all pins button (#6828)"}},{"before":null,"after":"5e4ec76d4637c34d5196e238031d79d69e6ff2d4","ref":"refs/heads/dependabot/npm_and_yarn/tar-6.2.1","pushedAt":"2024-04-11T05:16:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump tar from 6.1.12 to 6.2.1\n\nBumps [tar](https://github.com/isaacs/node-tar) from 6.1.12 to 6.2.1.\n- [Release notes](https://github.com/isaacs/node-tar/releases)\n- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.12...v6.2.1)\n\n---\nupdated-dependencies:\n- dependency-name: tar\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump tar from 6.1.12 to 6.2.1"}},{"before":"7d8f682ffcfacb32f5a2182802a270800eec0193","after":"6f1cbcb14511b8baa71f816fef24e9ca82691c93","ref":"refs/heads/master","pushedAt":"2024-04-10T20:58:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"yatbear","name":"Yating","path":"/yatbear","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15273931?s=80&v=4"},"commit":{"message":"Avoid failing directly when parsng Keras 2 layers (#6826)\n\nCurrently inbound node parsing is not backward compatible with Keras 2. Instead of failing directly, changed the code to return empty inbound node results.\r\n\r\nGooglers, see the description in cl/622948159 for context.\r\n\r\nTested internally: cl/582334596\r\n\r\n#keras3 #oncall","shortMessageHtmlLink":"Avoid failing directly when parsng Keras 2 layers (#6826)"}},{"before":"309771d797c3e97af9b0d8427377eaf7d8ed2a42","after":"7d8f682ffcfacb32f5a2182802a270800eec0193","ref":"refs/heads/master","pushedAt":"2024-04-08T16:53:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"yatbear","name":"Yating","path":"/yatbear","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15273931?s=80&v=4"},"commit":{"message":"Migrate graph plugin to Keras 3 and remove dependencies on Keras 2 and tf-keras-nightly (#6823)\n\nThis should fix the issue described in https://github.com/tensorflow/tensorboard/issues/6686. Compared the graph content with the one parsed from Keras 3, there are some changes in the structure and naming, this PR modifies the graph parsing accordingly.\r\n\r\nGooglers, see b/325451531 and b/312739672.\r\n\r\nTested with `tensorboard/plugins/graph:graphs_demo`:\r\n\r\n![image](https://github.com/tensorflow/tensorboard/assets/15273931/2e13205a-5ea2-437c-9fa7-3198f0eed1c5)\r\n\r\n#keras3 #oncall","shortMessageHtmlLink":"Migrate graph plugin to Keras 3 and remove dependencies on Keras 2 an…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAER_GbyAA","startCursor":null,"endCursor":null}},"title":"Activity · tensorflow/tensorboard"}