Enable to use newer protobuf #415
Open
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamcrume Could you check this PR if you have time? |
|
The problem is that the generated code (which is checked in) is only compatible with the exact same version of We could switch to generating the code in a build script, which means that we need the proto files available at build time. We could do that by adding TensorFlow as a git submodule, but it's huge (hundreds of megabytes), and apparently cargo doesn't work well with submodules (rust-lang/cargo#7987). Possibly a better way is to just manually (with a script) copy the protos from TensorFlow into this crate for each version upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414