Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency of proto msg's namespace #456

Open
hallazzang opened this issue Oct 15, 2021 · 0 comments
Open

inconsistency of proto msg's namespace #456

hallazzang opened this issue Oct 15, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@hallazzang
Copy link
Contributor

In the proto files, liquidity types are defined under tendermint.liquidity.v1beta1 package.

package tendermint.liquidity.v1beta1;

But for the query endpoints, it uses /cosmos/liquidity/v1beta1/ as the path prefix.

option (google.api.http).get = "/cosmos/liquidity/v1beta1/pools";

We have to make it consistent around the files not to confuse users.
But for backward compatibility we cannot change it now.
We can fix this maybe in the next version of the liquidity module.

@hallazzang hallazzang added the bug Something isn't working label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant