Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Enable Advanced Visibility #23

Open
gedw99 opened this issue Dec 13, 2021 · 7 comments
Open

Enable Advanced Visibility #23

gedw99 opened this issue Dec 13, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@gedw99
Copy link

gedw99 commented Dec 13, 2021

https://github.com/prabhatsharma/zinc

100% golang built on top of the excellent Bluge golang code.

This will work well with SQLite for a single binary solution.

the http api matches Elastic too so easy to plug into . Not everything is supported yet

has a web gui. Not sure if temporalite has one yet .

no cli yet , but relatively easy to do with cobra and making http calls to server . Might already be an issue for it.

it’s fast too .

I am using it and it’s been great .
It’s a new project and still got some rough edges compared to Elastic.

there is also the possibility to integrate via litestream but I doubt you need it. Litestream ( https://github.com/benbjohnson/litestream) gives you a type of changefeed off SQLite as well as real time backup to s3.

if you have any questions feel free to holler !

@gedw99 gedw99 added the enhancement New feature or request label Dec 13, 2021
@gedw99
Copy link
Author

gedw99 commented Dec 13, 2021

I just noticed that the sqlite driver is upstream.
So maybe the elasticlite (zinc) can be done the exact same way - upstream it.

@jlegrone
Copy link
Collaborator

Very cool! I was not aware of the zinc project. Upstreaming support in temporalio/temporal would be my preference, as the storage interfaces tend to change a bit and this would make it much easier to stay up to date with the latest Temporal server releases.

We're also looking at litestream, but not sure yet if it needs to be a direct integration (ie. pulling it in as a library vs. running alongside Temporalite). Mentioned this here: https://youtu.be/Hz7ZZzafBoE?t=655 😄

@gedw99
Copy link
Author

gedw99 commented Jan 13, 2022

hey @jlegrone

Very glad you are looking at litestream. it will be interesting if it can be HA'ed too. I spoke to Ben about the idea of doing CDC with litestream also.

Regarding Zinc. There is also a client implementation of elastic here: https://github.com/opensearch-project/opensearch-go The maintainer of Zinc knows about it...

@jlegrone
Copy link
Collaborator

jlegrone commented Jul 29, 2022

I believe there are plans to add full visibility features (eg. filtering by custom attributes) to all sql storage drivers in temporalio/temporal. This should avoid the need for an elastic replacement in Temporalite, since the full visibility API will be supported natively by the SQLite storage driver.

We can keep this issue open to track enabling advanced visibility in Temporalite though.

@jlegrone jlegrone changed the title Elastic lite replacement Enable Advanced Visibility Jul 29, 2022
@Irvenae
Copy link

Irvenae commented Apr 18, 2023

+1 for this

@karelbilek
Copy link

Advanced visibility is already done in temporal 1.22 for sqlite...

@karelbilek
Copy link

I don't think this repo is maintained.

But if it is, you can merge #234 and that could enable advanced visibility

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants