Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit failure cause depth #5763

Open
cretz opened this issue Apr 19, 2024 · 1 comment
Open

Limit failure cause depth #5763

cretz opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Apr 19, 2024

Describe the solution you'd like

Users can set very deep failure causes, and once it gets past 30 or so it breaks some protobuf parsers (any based on upb like Python and maybe Ruby/C/C++). We should limit the depth to something like 10/15. Can discuss implementation design on how this limitation occurs (not sure we should reject the failure but up to implementer). I can also provide more exact numbers on how deep before Python fails if that information is needed.

@cretz cretz added the enhancement New feature or request label Apr 19, 2024
@yiminc
Copy link
Member

yiminc commented Apr 26, 2024

Server is not crack open those failure and just pass it along. It would be hard for server to arbitrary determine what is the cutoff depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants