Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metrics name or allow to configure prefix #5679

Open
dpr-dev opened this issue Apr 8, 2024 · 0 comments
Open

Change metrics name or allow to configure prefix #5679

dpr-dev opened this issue Apr 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dpr-dev
Copy link

dpr-dev commented Apr 8, 2024

Is your feature request related to a problem? Please describe.
Hey, guys.
We encountered the following problem while configuring metrics for self hosted cluster. Metrics are not labeled with a special prefix, so there is no grouping for hundreds of metrics. This in turn makes it confusing, because it is not clear whose metrics they are exactly

The example on the screen from google cloud monitoring.

image image

Describe the solution you'd like
It would be cool if all metrics could be grouped under a common label, like Temporal, TemporalWorker, TemporalPoll, etc, so as not to pollute the overall scope.

Describe alternatives you've considered
On the other hand, it's a pretty breakable change. It may be possible to specify a prefix through env variables, which will be empty by default (for backward compatibility), which anyone can specify and thus change the name of metrics in monitoring systems if desired

@dpr-dev dpr-dev added the enhancement New feature or request label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant