Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying inserting Favicons by the Favicon Astroid settings. Doesnt Work? #617

Open
Chacapamac opened this issue Mar 24, 2024 · 3 comments
Open

Comments

@Chacapamac
Copy link
Collaborator

Chacapamac commented Mar 24, 2024

I create my icons at —> https://realfavicongenerator.net/

• I insert the files generated in a sub-folder to the root (e.g. “my-favicon”) with the “site.webmanifest” file and all images in.

Screen Shot 2024-03-24 at 10 15 18 AM

Note: remark the frontal backslash on the Astroid generated example when you said “Can be a relative path e.g. (manifest.json) e.g. (site.webmanifest) with no leading slash (/)” — Is this misleading?

— I insert and try both
my-favicon/site.webmanifest
and
/my-favicon/site.webmanifest

It is not working?

• If I take the “Custom Code” route, it work perfectly
e.g.

<!-- favicon links codes-->	
<link rel="apple-touch-icon" sizes="180x180" href="/my-favicon/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/my-favicon/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/my-favicon/favicon-16x16.png">
<link rel="manifest" href="/my-favicon/site.webmanifest">
<link rel="mask-icon" href="/my-favicon/safari-pinned-tab.svg" color="#5bbad5">
<link rel="shortcut icon" href="/my-favicon/favicon.ico">
<meta name="msapplication-TileColor" content="#da532c">
<meta name="msapplication-config" content="/my-favicon/browserconfig.xml">
<meta name="theme-color" content="#ffffff">
@sonvnn
Copy link
Member

sonvnn commented Mar 26, 2024

I fixed this issue in 887653d

Please help me check it.
Best Regards,
Sonny

@Chacapamac
Copy link
Collaborator Author

What code should I use to test?

my-favicon/site.webmanifest
or
/my-favicon/site.webmanifest

“my-favicon” is a folder in the root

@sonvnn
Copy link
Member

sonvnn commented Apr 3, 2024

What code should I use to test?

my-favicon/site.webmanifest or /my-favicon/site.webmanifest

“my-favicon” is a folder in the root

Sorry for late reply.
You can use "my-favicon/site.webmanifest"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants