Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unread message counter #775

Closed
Aokromes opened this issue May 31, 2015 · 16 comments
Closed

update unread message counter #775

Aokromes opened this issue May 31, 2015 · 16 comments

Comments

@Aokromes
Copy link
Collaborator

Aokromes commented May 31, 2015

i have some groups with 1000s of daily messages and sometimes i start to read the unread messages, but all the messages are marked as read i sugest to update the unread counter instead mark the whole group as read.

IE:
i have 1000 unread messages, i read 200, unread counter now shows 800 left.

edit for people unable to find this issue:

All messages in chat mark as read

Disable mark every message as read on open chat

displaying new-unread messages according to their viewing

Unread counter in windows desktop version

Unreaded posts in channels

Scrolling one unread message marks all as read

Opening chat group marks all messages as read, even unseen messages

Telegram mark all messages as read

All messages in chat mark as read

@enchained
Copy link

I think we're halfway there.
71e0e6a
In 1.3.7, I can confirm that, at least, the counter doesn't reset until I read to the very bottom.
Other things yet to confirm:

  • While coming back to continue catching up with messages, do you still lose your old reading position when there are new messages since then? It jumped right to the new messages in the past, losing the reading position, but now, without immediate counter reset, it could possibly be not an issue anymore.
  • Do you still lose your reading position on the app restart/crash? (too afraid to test).

I have a lot of messages in some channels and most of the time I was catching up with them in iOS Telegram X because it both updates the counter and remembers the position. but it would be much more comfortable to do so on the desktop, of course.

P.S. If your tdesktop version is less than 1.3.7 and it doesn't offer to update, simply download latest stable installer from here https://github.com/telegramdesktop/tdesktop/releases. I had that issue, possibly due to being in Russia. Didn't even knew about the update until I read it in the news and European friend said that her client just updated.

@john-preston
Copy link
Member

@enchained I'm afraid currently this is a bug 😭

@smasharov
Copy link

I have to read some channels on my mobile device (telegram X) because of that.

@nuclight
Copy link

Vote up this bug, very annoying to have to read some chats on mobile.

@nuclight
Copy link

@auchri this is wrong label "enhancement", this is definetely a bug as tdesktop behaviour here is differ from "upstream" mobile platform

@nuclight
Copy link

nuclight commented Jul 7, 2019

Vote up. This is especially needed soon as some platforms/versions support will be dropped in next months.

@nuclight
Copy link

Where could be priority of bugs / work plans on them could be seen?

@aNNiMON
Copy link

aNNiMON commented Sep 21, 2019

Please, rename this issue for better understanding and search purposes

@JSBmanD
Copy link

JSBmanD commented Sep 21, 2019

Why this issue is here from 2015? It's a bug that shouldn't be in a modern messenger app. In Telegram X on mobile everything is ok. It's inconsistent with all mobile clients.

@Aokromes
Copy link
Collaborator Author

pull requests fixing this bug are welcomed.

@kirsan31
Copy link
Contributor

kirsan31 commented Oct 18, 2019

I have looked into the code... And this is not a simple bug :( This is not implemented at all.
For entering a chat (for channels a bit differ) with a new messages current algorithm is: if we are reading server history (have loaded unread messages from server - have opened chat with unread messages) - tell server that we have read all downloaded messages regardless of current scroll position.
For new messages in current opened chat similar problem, but different code. And you need take this into account:

Snipaste_2019-10-18_17-12-13

So, for fixing this bug existing implementation must be seriously extended. For doing this right, we need to understand current one. And for me it will take too mach time :( This job is for @john-preston :)

@Ali-Hamed
Copy link

Ali-Hamed commented Jan 2, 2020

this definitely a popular bug since @Aokromes opened the issue on May 31, 2015 ,almost 5 years (1677 days) with no progress.
insane 😒😢

@aryanrawlani28
Copy link

My apologies. I tried searching but didn't think this issue went all the way back to 2015. Crazy!
Hope we can fix this somehow!

@kirsan31
Copy link
Contributor

I can add to my research, that definitely this is not an enhancement this is 100% bug...

@Aokromes Aokromes changed the title update unread counter update unread message counter Jan 17, 2020
@23rd 23rd closed this as completed Feb 21, 2020
@Aokromes
Copy link
Collaborator Author

theoricaly fixed by future 1.9.15

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests