Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete EventListener with servicePort configured #1561

Open
m1n-q opened this issue Mar 18, 2023 · 8 comments
Open

Cannot delete EventListener with servicePort configured #1561

m1n-q opened this issue Mar 18, 2023 · 8 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@m1n-q
Copy link

m1n-q commented Mar 18, 2023

Expected Behavior

Deletion should be performed normally.

Actual Behavior

Got an error:

Error from server (BadRequest): error when deleting "eventlistener-serviceconfig.yaml": admission webhook "validation.webhook.triggers.tekton.dev" denied the request: decoding request failed: cannot decode incoming old object: json: unknown field "servicePort"

Steps to Reproduce the Problem

  1. create EventListener resource with spec.resources.kubernetesResource.servicePort configured
  2. delete EventListener

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.2", GitCommit:"fc04e732bb3e7198d2fa44efa5457c7c6f8c0f5b", GitTreeState:"clean", BuildDate:"2023-02-22T13:32:21Z", GoVersion:"go1.20.1", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.2", GitCommit:"fc04e732bb3e7198d2fa44efa5457c7c6f8c0f5b", GitTreeState:"clean", BuildDate:"2023-02-22T13:32:22Z", GoVersion:"go1.19.6", Compiler:"gc", Platform:"linux/amd64"}
  • Tekton Pipeline version: v0.45.0

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

It only works properly after the servicePort has been deleted with kubectl edit.

@m1n-q m1n-q added the kind/bug Categorizes issue or PR as related to a bug. label Mar 18, 2023
@khrm
Copy link
Contributor

khrm commented Mar 20, 2023

What's the triggers version, @m1n-q ?

@khrm khrm self-assigned this Mar 20, 2023
@m1n-q
Copy link
Author

m1n-q commented Mar 20, 2023

@khrm

$ tkn version
Client version: 0.29.1
Pipeline version: v0.45.0
Triggers version: v0.23.0

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2023
@khrm
Copy link
Contributor

khrm commented Aug 8, 2023

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2023
@khrm
Copy link
Contributor

khrm commented Aug 8, 2023

/lifecycle frozen

This needs to be fixed. Hopefully in the next release.

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 8, 2023
@khrm
Copy link
Contributor

khrm commented Aug 18, 2023

I am not able to recreate his issue. Does it exist in v0.24.0?

@khrm
Copy link
Contributor

khrm commented Aug 18, 2023

@m1n-q Can you check whether it exists now or not?

@khrm khrm modified the milestones: Triggers v0.25, Triggers v0.26 Aug 25, 2023
@khrm
Copy link
Contributor

khrm commented Oct 18, 2023

/remove lifecycle frozen

@khrm khrm removed this from the Triggers v0.26 milestone Oct 18, 2023
@khrm khrm removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants